graduate ServiceIPStaticSubrange to GA #37432

aojea · 2022-10-21T13:32:43Z

The ServiceIPStaticSubrange feature gate, that allows to change the IP allocation algorithm used for Service.ClusterIPs, is graduating to GA.

aojea · 2022-10-21T13:33:50Z

/assign @sftim @thockin

netlify · 2022-10-21T13:45:52Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`56cd998`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63529f7de2fa400008b39be7
😎 Deploy Preview	https://deploy-preview-37432--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thockin

Thanks!

/lgtm
/approve

sftim · 2022-10-21T22:32:22Z

Please target this change to the dev-1.26 branch @aojea

/hold
OK to unhold once the target branch is right

netlify · 2022-10-22T07:44:00Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`e8199cf`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/638624a5e3dc680008b729cc

aojea · 2022-10-22T07:45:39Z

@sftim updated the PR against 1.26

jihoon-seo · 2022-10-26T08:57:07Z

/unhold
since:

OK to unhold once the target branch is right

aojea · 2022-10-26T18:48:44Z

@thockin @sftim the lgtm and approve tags were dropped after the rebase, can you please take a look again

content/en/docs/concepts/services-networking/service.md

sftim · 2022-11-13T23:17:01Z

What I don't get from these docs is: can you have more than 256 Services in your cluster? It's not obvious how the whole available range eventually gets used.

aojea · 2022-11-14T00:02:09Z

What I don't get from these docs is: can you have more than 256 Services in your cluster? It's not obvious how the whole available range eventually gets used.

ups, no, the number of Services is not modified here, this makes a virtual division to not allocate dynamic addresses from this lower range, the blog explains it in more detail https://kubernetes.io/blog/2022/05/23/service-ip-dynamic-and-static-allocation/

sftim · 2022-11-14T09:13:13Z

the blog explains it in more detail https://kubernetes.io/blog/2022/05/23/service-ip-dynamic-and-static-allocation/

I'd like to be able to work out the way it works just from the docs - and I want that for readers in general too. For GA, we prefer to have docs that readers can understand without also following links to the KEP, post-release writeup, etc.

sftim · 2022-11-14T09:15:43Z

It's OK to copy from that blog article, as much as we'd like to. It's also reasonable to change that blog article to be evergreen: written so that the text doesn't turn stale, and marked as such. Only some minor tweaks would be needed there, and then we can link to it to provide the background detail (we can actually shorten the concept page if we do that).

aojea · 2022-11-18T00:07:48Z

ack, let me work on this

content/en/docs/concepts/services-networking/service.md

content/en/docs/reference/command-line-tools-reference/feature-gates.md

aojea · 2022-11-18T08:42:04Z

It's OK to copy from that blog article, as much as we'd like to. It's also reasonable to change that blog article to be evergreen: written so that the text doesn't turn stale, and marked as such. Only some minor tweaks would be needed there, and then we can link to it to provide the background detail (we can actually shorten the concept page if we do that).

@sftim I've tried to follow your suggestions but I need you to review because I'm not sure if that is what you meant

aojea · 2022-11-26T16:59:32Z

ping @sftim

tengqm · 2022-11-27T02:02:34Z

content/en/docs/concepts/services-networking/cluster-ip-allocation.md

+#### Service IP CIDR block: 10.96.0.0/24
+
+Range Size: 2<sup>8</sup> - 2 = 254  
+Band Offset: `min(max(16, 256/16), 256)` = `min(16, 256)` = 16  
+Static band start: 10.96.0.1  
+Static band end: 10.96.0.16  
+Range end: 10.96.0.254   


Two problems here:

We usually don't have H4 for headings, and in this context, we are skipping H3?

The text lines above would be converted into a single text graph, difficult to read.

Em... interesting that the lines above are not merged by Hugo.

I copied from the blog article, but open to suggestions since I'm not very deep in docs/text format

Em... interesting that the lines above are not merged by Hugo.

The inline HTML might prevent that. Not sure.

sftim

Thanks

Here's some feedback

content/en/docs/concepts/services-networking/cluster-ip-allocation.md

sftim · 2022-11-28T21:26:44Z

content/en/docs/concepts/services-networking/cluster-ip-allocation.md

+reviewers:
+- sftim
+- thockin
+title: Service ClusterIP allocation


Is it a ClusterIP, or just a virtual cluster IP? I'm not sure on the need for writing this text monospace. Bear in mind that the Service that gets one of these virtual IP addresses might not have the type field set to "ClusterIP". For example, it could be a Service of type: LoadBalancer.

this is ClusterIP specific, the LoadBalancer IP is assigned by an external controller and not explained here ... all Services types have a ClusterIP except, headless that use ClusterIP: None or those with type ExternalName

all Services type have a ClusterIP

Right, that's the bit where I'm worried we're confusing readers. In Kubernetes, most Services have a thing, but should we call the thing a ClusterIP? To me ClusterIP is a particular enum value. We wouldn't, for example, write:
“the packets are rewritten as they pass through the LoadBalancer”, even though LoadBalancer is the type of Service involved there.

I see your point, let me summon @danwinship and @thockin they are good expressing these concepts

content/en/docs/concepts/services-networking/cluster-ip-allocation.md

Co-authored-by: Tim Bannister <tim@scalefactory.com>

sftim · 2022-11-29T15:42:26Z

If the rest of the page is technically accurate, let's ship. Would be nice to see if we can tidy further before the release.

/approve

k8s-ci-robot · 2022-11-29T15:42:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sftim · 2022-11-29T15:59:41Z

/lgtm

k8s-ci-robot · 2022-11-29T15:59:46Z

LGTM label has been added.

Git tree hash: ca5219a653d552f4fb5d3d2bce1cf3c150d9deaf

mickeyboxell · 2022-11-29T16:03:10Z

/lgtm

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 21, 2022

k8s-ci-robot requested review from mehabhalodiya and tengqm October 21, 2022 13:32

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2022

aojea mentioned this pull request Oct 21, 2022

Reserve Service IP Ranges For Dynamic and Static IP Allocation kubernetes/enhancements#3070

Closed

k8s-ci-robot assigned sftim and thockin Oct 21, 2022

thockin reviewed Oct 21, 2022

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2022

aojea changed the base branch from main to dev-1.26 October 22, 2022 03:20

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2022

aojea force-pushed the static_service_ga branch from 56cd998 to 7fa9682 Compare October 22, 2022 07:43

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2022

k8s-ci-robot requested review from sftim and thockin October 22, 2022 07:43

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 22, 2022

aojea force-pushed the static_service_ga branch from 7fa9682 to 6336cb9 Compare October 22, 2022 07:45

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2022

sftim reviewed Nov 13, 2022

View reviewed changes

content/en/docs/concepts/services-networking/service.md Show resolved Hide resolved

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 17, 2022

tengqm reviewed Nov 18, 2022

View reviewed changes

graduate ServiceIPStaticSubrange to GA

6f7421b

aojea force-pushed the static_service_ga branch from b620995 to 6f7421b Compare November 18, 2022 08:40

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2022

tengqm reviewed Nov 27, 2022

View reviewed changes

sftim reviewed Nov 28, 2022

View reviewed changes

aojea commented Nov 29, 2022

View reviewed changes

content/en/docs/concepts/services-networking/cluster-ip-allocation.md Outdated Show resolved Hide resolved

aojea commented Nov 29, 2022

View reviewed changes

content/en/docs/concepts/services-networking/cluster-ip-allocation.md Outdated Show resolved Hide resolved

Apply suggestions from code review

e8199cf

Co-authored-by: Tim Bannister <tim@scalefactory.com>

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2022

k8s-ci-robot merged commit 0f3666f into kubernetes:dev-1.26 Nov 29, 2022

k8s-ci-robot added this to the 1.26 milestone Nov 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

graduate ServiceIPStaticSubrange to GA #37432

graduate ServiceIPStaticSubrange to GA #37432

aojea commented Oct 21, 2022 •

edited

Loading

aojea commented Oct 21, 2022

netlify bot commented Oct 21, 2022

thockin left a comment

sftim commented Oct 21, 2022

netlify bot commented Oct 22, 2022 •

edited

Loading

aojea commented Oct 22, 2022

jihoon-seo commented Oct 26, 2022

aojea commented Oct 26, 2022

sftim commented Nov 13, 2022

aojea commented Nov 14, 2022

sftim commented Nov 14, 2022

sftim commented Nov 14, 2022

aojea commented Nov 18, 2022

aojea commented Nov 18, 2022

aojea commented Nov 26, 2022

tengqm Nov 27, 2022

tengqm Nov 27, 2022

aojea Nov 27, 2022

sftim Nov 28, 2022

sftim left a comment

sftim Nov 28, 2022

aojea Nov 29, 2022 •

edited

Loading

sftim Nov 29, 2022 •

edited

Loading

aojea Nov 29, 2022

sftim commented Nov 29, 2022

k8s-ci-robot commented Nov 29, 2022

sftim commented Nov 29, 2022

k8s-ci-robot commented Nov 29, 2022

mickeyboxell commented Nov 29, 2022

graduate ServiceIPStaticSubrange to GA #37432

graduate ServiceIPStaticSubrange to GA #37432

Conversation

aojea commented Oct 21, 2022 • edited Loading

aojea commented Oct 21, 2022

netlify bot commented Oct 21, 2022

✅ Pull request preview available for checking

thockin left a comment

Choose a reason for hiding this comment

sftim commented Oct 21, 2022

netlify bot commented Oct 22, 2022 • edited Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

aojea commented Oct 22, 2022

jihoon-seo commented Oct 26, 2022

aojea commented Oct 26, 2022

sftim commented Nov 13, 2022

aojea commented Nov 14, 2022

sftim commented Nov 14, 2022

sftim commented Nov 14, 2022

aojea commented Nov 18, 2022

aojea commented Nov 18, 2022

aojea commented Nov 26, 2022

tengqm Nov 27, 2022

Choose a reason for hiding this comment

tengqm Nov 27, 2022

Choose a reason for hiding this comment

aojea Nov 27, 2022

Choose a reason for hiding this comment

sftim Nov 28, 2022

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

sftim Nov 28, 2022

Choose a reason for hiding this comment

aojea Nov 29, 2022 • edited Loading

Choose a reason for hiding this comment

sftim Nov 29, 2022 • edited Loading

Choose a reason for hiding this comment

aojea Nov 29, 2022

Choose a reason for hiding this comment

sftim commented Nov 29, 2022

k8s-ci-robot commented Nov 29, 2022

sftim commented Nov 29, 2022

k8s-ci-robot commented Nov 29, 2022

mickeyboxell commented Nov 29, 2022

aojea commented Oct 21, 2022 •

edited

Loading

netlify bot commented Oct 22, 2022 •

edited

Loading

aojea Nov 29, 2022 •

edited

Loading

sftim Nov 29, 2022 •

edited

Loading