Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links in crd-versions docs based on the latest k8s release #37506

Merged

Conversation

mboukhalfa
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 25, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2022
@mboukhalfa mboukhalfa force-pushed the update-link-in-crd-versions/mohammed branch from f75f328 to 0e569cc Compare October 25, 2022 11:13
@netlify
Copy link

netlify bot commented Oct 25, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f75f328
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6357c203aee9920008d493e1
😎 Deploy Preview https://deploy-preview-37506--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 25, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0e569cc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6357c4dae7f3bb0008d04fd7
😎 Deploy Preview https://deploy-preview-37506--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to “permalink” to specific commits. However, this is OK.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa0fffcb9cb6d8c89db12a2aa15057c888e2362f

@sftim
Copy link
Contributor

sftim commented Oct 29, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 808f74b into kubernetes:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants