Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kep 2133: update doc references and standardize the content for KubeletCredentialsProvider #38006

Closed
wants to merge 139 commits into from
Closed

Kep 2133: update doc references and standardize the content for KubeletCredentialsProvider #38006

wants to merge 139 commits into from

Conversation

ndixita
Copy link
Contributor

@ndixita ndixita commented Nov 21, 2022

Signed-off-by: Narang Dixita Sohanlal ndixita@google.com

Adding doc changes for kep-2133 for KubeletCredentialProviders GA.
kubernetes/enhancements#2133

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @ndixita!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 21, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 21, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 21, 2022
@ndixita
Copy link
Contributor Author

ndixita commented Nov 21, 2022

/assign @sftim
/assign @andrewsykim
/assign @ruiwen-zhao

@netlify
Copy link

netlify bot commented Nov 22, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit abf3928
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/638549bd8361e30009f4dd7a
😎 Deploy Preview https://deploy-preview-38006--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ruiwen-zhao
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 070470fa0b0bcc488260c0c333b9201049e95b4d

@andrewsykim andrewsykim mentioned this pull request Nov 22, 2022
Closed
@ndixita ndixita force-pushed the kep-2133 branch 2 times, most recently from 835a1de to eb92ce0 Compare November 22, 2022 05:37
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@ndixita ndixita force-pushed the kep-2133 branch 2 times, most recently from 9878c44 to 018fe0a Compare November 27, 2022 05:52
andrewsykim
andrewsykim reviewed Nov 28, 2022
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @sftim's comment in #37920 (review), I think we should have a new section in here, that links to kubelet-credential-provider.md.

content/en/docs/reference/command-line-tools-reference/feature-gates.md Show resolved Hide resolved
@krol3
Copy link
Contributor

krol3 commented Nov 28, 2022 •
edited
Loading

@ndixita Please change the branch against dev-126. This PR needs a doc review by Mon Nov 28th to get this into the release. Please reach out to required SIGs to get their review. Thank you!
cc: @katmutua @reylejano

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022
@netlify
Copy link

netlify bot commented Nov 28, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 68c1e1e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/63854add8e59fe0008ccc651

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from reylejano by writing /assign @reylejano in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divya-mohan0209
Copy link
Contributor

@ndixita I think the rebase added in all previous commits to the k/website repo. You can either try resolving the issue OR open a new PR with the suggested changes & request for a re-review.

@krol3
Copy link
Contributor

krol3 commented Nov 29, 2022

@ndixita is this PR #38139 supersede this draft PR?
cc: @sftim @reylejano @katmutua

@leonardpahlke
Copy link
Member

@ndixita 1.26 is scheduled to get released in less than a week, how much do you think is needed to get this PR merged?

@krol3 krol3 mentioned this pull request Dec 2, 2022
Merged
@ndixita ndixita closed this Dec 2, 2022
@jihoon-seo
Copy link
Member

/remove-area blog release-eng
/remove-language de fr hi it ja pt ru zh
/remove-sig release

@k8s-ci-robot k8s-ci-robot removed area/blog Issues or PRs related to the Kubernetes Blog subproject area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruiwen-zhao ruiwen-zhao ruiwen-zhao left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@liggitt liggitt Awaiting requested review from liggitt

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@sftim sftim Awaiting requested review from sftim

Assignees

@ruiwen-zhao ruiwen-zhao

@andrewsykim andrewsykim

@sftim sftim

@reylejano reylejano

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.