Recommend DNS Labels for workload controller names #38499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
sig/docs
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site settings. |
sftim
reviewed
Dec 15, 2022
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0dabba1a3f4462f9e065452d4e67a6cccd16781c
|
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/M
|
Updated other types - PTAL |
thockin
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
sftim
reviewed
Dec 16, 2022
content/en/docs/concepts/workloads/controllers/replicationcontroller.md
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 409c2c374262009a7c56f0c72a6ba798c5137bd8
|
k8s-ci-robot
removed
the
lgtm
|
Thanks for the word tweaking. New push is up. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: aa6e83ae45a98f963c77f82eaa84c2eea1c25142
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sftim - you suggested this in kubernetes/kubernetes#114412 (comment) - help me craft wording? Once we are happy with words I will apply the same pattern to other types.