Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Update outdated files in dev-1.26-ko.1 (M111) #38505

Merged
merged 1 commit into from
Feb 24, 2023
Merged

[ko] Update outdated files in dev-1.26-ko.1 (M111) #38505

merged 1 commit into from
Feb 24, 2023

Conversation

jihoon-seo
Copy link
Member

Related issue: #38458

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2022
@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Dec 16, 2022
@k8s-ci-robot k8s-ci-robot requested a review from yoonian December 16, 2022 06:05
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 16, 2022
@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 91ae8b2
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/63f8647deb3d9c000849b81d
😎 Deploy Preview https://deploy-preview-38505--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

seokho-son
seokho-son reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoon-seo 감사합니다! :)

content/ko/docs/reference/command-line-tools-reference/feature-gates-removed.md Outdated
@@ -0,0 +1,679 @@
---
title: Feature Gates (removed)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한글화가 가능해보입니다.

content/ko/docs/reference/command-line-tools-reference/feature-gates-removed.md Outdated Show resolved Hide resolved
@seokho-son
Copy link
Member

/assign @seokho-son

@seokho-son
Copy link
Member

@jihoon-seo 상기 리뷰 의견만 반영해주시면 ~ 승인하도록 하겠습니다~~

@jihoon-seo jihoon-seo force-pushed the 221215_ko_Update_outdated_M111 branch from 98e7d5e to 91ae8b2 Compare February 24, 2023 07:17
@jihoon-seo
Copy link
Member Author

@seokho-son 반영하였습니다. 감사합니다.
그리고 title: Feature Gates (removed) 부분은
"기능 게이트 (제거됨)" 또는 "(제거된) 기능 게이트" 보다는
"제거된 기능 게이트" 로 기재하는 것이 나을 것 같아서 이렇게 하였습니다.
참고 및 확인 부탁드립니다. 😊

@seokho-son
Copy link
Member

감사합니다!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 18b818062fc3b2296dc5d8077fb0e93a6ed0f5a3

@seokho-son
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 423ad83 into kubernetes:dev-1.26-ko.1 Feb 24, 2023
@jihoon-seo jihoon-seo deleted the 221215_ko_Update_outdated_M111 branch September 20, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@yoonian yoonian Awaiting requested review from yoonian

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jihoon-seo @seokho-son @k8s-ci-robot