Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagrams for Virtual IPs and Service Proxies #38542

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Improve diagrams for Virtual IPs and Service Proxies #38542

merged 2 commits into from
Jan 27, 2023

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Dec 18, 2022 •
edited
Loading

I adapted one of the commits from #38455 as a way to address #38165

sftim and others added 2 commits December 18, 2022 19:48
@sftim
Replace images for Virtual IPs and Service Proxies
ae0089a 
Co-Authored-By: Tamilselvan Thangamony <tamilselvan.t@india.nec.com>
@sftim
Commit rendered images for virtual IPs reference
71180ea 
- Convert text to curves
- Slight tweaks

Co-Authored-By: Tamilselvan Thangamony <tamilselvan.t@india.nec.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 18, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 18, 2022
@sftim sftim mentioned this pull request Dec 18, 2022
Closed
@netlify
Copy link

netlify bot commented Dec 18, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 71180ea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/639f76e11214a100082975fb
😎 Deploy Preview https://deploy-preview-38542--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

divya-mohan0209
divya-mohan0209 reviewed Dec 23, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the ipvs diagram, would we benefit from retaining the virtual server labelling since we have stated that the backend pods are on the real server? This otherwise LGTM, thanks!

@sftim
Copy link
Contributor Author

sftim commented Jan 24, 2023

For the ipvs diagram, would we benefit from retaining the virtual server labelling since we have stated that the backend pods are on the real server?

I think it's misleading and helpful in equal measure, and that's why I omitted it. There's still room to improve on these diagrams but I think they're better than what we have now.

divya-mohan0209
divya-mohan0209 reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, @sftim ! LGTM from my side :)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 31f8f7eb081fade5989c94dbf34621d2b705d864

@nate-double-u
Copy link
Contributor

Thanks for these @sftim! I agree, these are clearer and more legible than the previous set. Let's merge this in and if we need to make further changes those can be in a separate PR.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nate-double-u

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit e410f99 into kubernetes:main Jan 27, 2023
@sftim sftim deleted the 20221218_update_virtual_ip_reference_images branch January 28, 2023 18:28
@tamilselvan1102 tamilselvan1102 mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@divya-mohan0209 divya-mohan0209

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @k8s-ci-robot @nate-double-u @divya-mohan0209