-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move AWS Service annotation details to reference page #38551
Move AWS Service annotation details to reference page #38551
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
9036146
to
a4cf09b
Compare
a4cf09b
to
48a832a
Compare
This is NICE. |
LGTM label has been added. Git tree hash: f037617245669dd1c40ddd33483da17a3ae40c36
|
I understood that all annotations with alpha or beta in their name were deprecated and that SIGs should look to move away. Since I opened this PR, I found https://cloud-provider-aws.sigs.k8s.io/service_controller/ and also https://cloud-provider-azure.sigs.k8s.io/topics/loadbalancer/
|
My take is that most of the providers of those APIs are cautious about the "maturity level" of their technologies. |
I'll ask SIG Architecture how we should mark 'em. The thing that makes them deprecated isn't the beta status, it's putting the status in the annotation key. The modern way is to use the same key, without an alpha or beta substring, all the way to GA. |
48a832a
to
ee4c1f7
Compare
bd45bb2
to
6144923
Compare
Ok, I think this is ready for review. |
I just went with marking all but one actually-deprecated annotation as beta. |
Changes since last LGTM |
a7405a5
to
8f87def
Compare
All changes since #38551 (comment) are just rebases. |
8f87def
to
7706e48
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7706e48
to
9edd20b
Compare
9edd20b
to
bca32b1
Compare
bca32b1
to
5a98033
Compare
wow, half a year passed. |
LGTM label has been added. Git tree hash: c548d94c05dbb2cc1c90d4996bb32e7468aa2602
|
https://kubernetes.io/docs/concepts/services-networking/service/ has a bunch of specific details for one cloud provider, AWS.
These belong elsewhere; there are already good homes at https://cloud-provider-aws.sigs.k8s.io/service_controller/ and https://kubernetes-sigs.github.io/aws-load-balancer-controller/latest/, so we can omit them from the Service page.
I updated https://kubernetes.io/docs/reference/labels-annotations-taints/ to list all the AWS annotations for Services,
and I marked all of those as deprecated because they include.beta.
in the subdomain part of the label key (which is a generally deprecated practice).Preview of the revised Service page.
Openquestion, though: should we link from https://kubernetes.io/docs/concepts/services-networking/service/ to https://cloud-provider-aws.sigs.k8s.io/service_controller/ and to https://kubernetes-sigs.github.io/aws-load-balancer-controller/latest/?marking as Draft because of the open question