-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc update for KEP-3352 Aggregated Discovery #40024
Conversation
Hi @Jefftree, when you're ready, populate your placeholder PR with feature documentation and change the state of the PR from draft to ready for review. The official Docs deadline for PRs to be ready for review is tomorrow, March 21st. All docs PRs must be reviewed and ready to merge by April 4th. To mark a pull request as ready for review, navigate to the merge box and click Ready for review. Regarding the content of your documentation, do your best to describe your feature and how to use it. If you need help structuring your documentation, ask in the #sig-docs Slack channel. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline. This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you! |
123de2f
to
0932a5c
Compare
8f8dcdd
to
2af591d
Compare
@Jefftree I see you added content to the docs. If this is ready for review, please change the state of the PR from draft to ready for review. |
2af591d
to
9d15d73
Compare
9d15d73
to
b677f2a
Compare
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
/cc @seans3 @alexzielenski |
Looks good, thanks. Technical LGTM |
@Jefftree would you mind rebasing when you get the chance? |
b677f2a
to
dd1c643
Compare
/label tide/merge-method-squash |
LGTM label has been added. Git tree hash: 00546cdd580a1bc7f2dc86c84f1af6266e7c496e
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes/enhancements#3352