KEP-3488 ValidatingAdmissionPolicy post-1.27 update #40054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
jiahuif
changed the title
|
/sig api-machinery |
k8s-ci-robot
added
sig/api-machinery
|
/language en |
16 tasks
|
Hi @jiahuif 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline. This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required the SIGs to get their review. Thank you! |
k8s-ci-robot
added
sig/docs
jiahuif
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
jiahuif
force-pushed
the
feature/validating-admission-policy/post-1.27
branch
6 times, most recently
from
874ce4d
to
6af5478
Compare
jiahuif
commented
Mar 21, 2023
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
jpbetz
suggested changes
Mar 21, 2023
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Show resolved
Hide resolved
jiahuif
force-pushed
the
feature/validating-admission-policy/post-1.27
branch
4 times, most recently
from
48f519f
to
c88f863
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 823464a06c7a6756f8d5eb985dfd47e0b8a078a2
|
|
/approve |
k8s-ci-robot
added
the
needs-rebase
jiahuif
force-pushed
the
feature/validating-admission-policy/post-1.27
branch
from
c88f863
to
5a500dc
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5f468ec274d0475f67575c2aa97b1cfe820aa92c
|
|
Hi @mickeyboxell ! Now that this PR has the technical review, could you give it a pass to merge it? Thank you. |
tengqm
reviewed
Mar 31, 2023
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Show resolved
Hide resolved
content/en/docs/reference/access-authn-authz/validating-admission-policy.md
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
needs-rebase
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
jiahuif
force-pushed
the
feature/validating-admission-policy/post-1.27
branch
from
930632c
to
1df930d
Compare
k8s-ci-robot
removed
the
needs-rebase
jiahuif
force-pushed
the
feature/validating-admission-policy/post-1.27
branch
from
1df930d
to
0d862b9
Compare
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 84a78ddb51e0f1287b62659ae999b1a683c66464
|
jpbetz
approved these changes
Apr 3, 2023
|
/approve |
|
@tengqm Thank you very much for your review. I've added and squashed all suggestions. The PR was rebased due to a merge conflict. Could you take another look during your uptime? Thank you. |
|
Thank you for replying to comments |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers the following new features of ValidatingAdmissionPolicy
This PR is ready for review.
KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/3488-cel-admission-control