Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Update outdated files in dev-1.26.-ko.1 [M149-155] #40938

Merged
merged 1 commit into from
May 22, 2023
Merged

[ko] Update outdated files in dev-1.26.-ko.1 [M149-155] #40938

merged 1 commit into from
May 22, 2023

Conversation

Virusuki
Copy link
Contributor

@Virusuki Virusuki commented May 2, 2023

Related Issue: #38458

Updated outdated files in content/en/docs/tasks/.

7 files to be modified

  • M149. content/en/docs/tasks/administer-cluster/cluster-upgrade.md | 9(+XS) 0(-)
  • M150. content/en/docs/tasks/administer-cluster/dns-custom-nameservers.md | 59(+M) 112(-)
  • M151. content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md | 4(+XS) 4(-)
  • M152. content/en/docs/tasks/administer-cluster/manage-resources/memory-default-namespace.md | 8(+XS) 0(-)
  • M153. content/en/docs/tasks/administer-cluster/network-policy-provider/cilium-network-policy.md | 26(+S) 30(-)
  • M154. content/en/docs/tasks/administer-cluster/use-cascading-deletion.md | 1(+XS) 141(-)
  • M155. content/en/docs/tasks/configmap-secret/managing-secret-using-config-file.md | 55(+M) 1(-)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2023
@k8s-ci-robot k8s-ci-robot requested review from jihoon-seo and pjhwa May 2, 2023 22:38
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 2, 2023
@netlify
Copy link

netlify bot commented May 2, 2023 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 5cc285f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/645f88d97a12a50008ed9721
😎 Deploy Preview https://deploy-preview-40938--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ysyukr
Copy link
Member

ysyukr commented May 3, 2023

/assign

jongwooo
jongwooo suggested changes May 8, 2023
View reviewed changes
Copy link
Member

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요! 몇 가지 코멘트를 추가해보았습니다. 살펴보시고, 적절히 적용해주시면 감사하겠습니다.

content/ko/docs/tasks/administer-cluster/dns-custom-nameservers.md Outdated Show resolved Hide resolved
content/ko/docs/tasks/administer-cluster/manage-resources/memory-default-namespace.md Outdated Show resolved Hide resolved
content/ko/docs/tasks/administer-cluster/network-policy-provider/cilium-network-policy.md Outdated Show resolved Hide resolved
content/ko/docs/tasks/configmap-secret/managing-secret-using-config-file.md Outdated Show resolved Hide resolved
@Virusuki
Copy link
Contributor Author

@jongwooo 목적격 조사와 놓친 평어체 부분 수정했습니다.
리뷰 감사합니다~ㅎㅎ

@Virusuki
[ko] Update outdated files in dev-1.26.-ko.1 [M149-155]
5cc285f 
Update outdated files in dev-1.26.-ko.1 [M149-155]
@Virusuki Virusuki force-pushed the dev-1.26-ko.1-outdated branch from 801be95 to 5cc285f Compare May 13, 2023 12:55
@ysyukr
Copy link
Member

ysyukr commented May 22, 2023

@Virusuki, @jongwooo 확인이 늦었습니다.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 87ba807487ab75df13a2114e4a1ea8d1b15d1718

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ysyukr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 56e300c into kubernetes:dev-1.26-ko.1 May 22, 2023
@Virusuki
Copy link
Contributor Author

네 확인감사합니다. 👍

@Virusuki Virusuki mentioned this pull request Jun 8, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongwooo jongwooo jongwooo requested changes

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo

@pjhwa pjhwa Awaiting requested review from pjhwa

Assignees

@ysyukr ysyukr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Virusuki @ysyukr @k8s-ci-robot @jongwooo