Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3325: Promote SelfSubjectReview to GA #40956

Merged
merged 2 commits into from
May 5, 2023
Merged

KEP-3325: Promote SelfSubjectReview to GA #40956

merged 2 commits into from
May 5, 2023

Conversation

nabokihms
Copy link
Member

@nabokihms nabokihms commented May 4, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 4, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 4, 2023
@nabokihms
Copy link
Member Author

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label May 4, 2023
@nabokihms nabokihms mentioned this pull request May 4, 2023
Closed
12 tasks
@nabokihms
KEP-3325: Promote SelfSubjectReview to GA
d2d1242 
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
@nabokihms nabokihms changed the title KEP-3325: Promote SelfSubjectReview to Beta KEP-3325: Promote SelfSubjectReview to GA May 4, 2023
@netlify
Copy link

netlify bot commented May 4, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d2d1242
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64537cd33ca0650008e3024f
😎 Deploy Preview https://deploy-preview-40956--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented May 4, 2023

Is this for v1.28? Please target the dev-1.28 branch rather than main if so.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@nabokihms nabokihms changed the base branch from main to dev-1.28 May 4, 2023 14:00
@nabokihms
Copy link
Member Author

Rebased, thanks

@liggitt
Copy link
Member

liggitt commented May 4, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f899b8f1738315287a39fdd3bf5407da5ad87f8

@tengqm
Copy link
Contributor

tengqm commented May 4, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
sftim
sftim reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

I'd tweak this slightly.

content/en/docs/reference/access-authn-authz/authentication.md Outdated Show resolved Hide resolved
content/en/docs/reference/access-authn-authz/authentication.md Outdated Show resolved Hide resolved
@nabokihms @sftim
Apply suggestions from code review
3084195 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from liggitt May 4, 2023 20:25
@nabokihms nabokihms requested a review from sftim May 4, 2023 22:06
@tengqm
Copy link
Contributor

tengqm commented May 5, 2023

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b0bdf383409e9c41ac6e2c73d36165b403145b40

@k8s-ci-robot k8s-ci-robot merged commit 77709a9 into kubernetes:dev-1.28 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@liggitt liggitt Awaiting requested review from liggitt

@sftim sftim Awaiting requested review from sftim

Assignees

@liggitt liggitt

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabokihms @tengqm @liggitt @k8s-ci-robot @sftim