Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document detail about headless Services #41195

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Document detail about headless Services #41195

merged 1 commit into from
Jul 1, 2023

Conversation

sftim
Copy link
Contributor

@sftim sftim commented May 17, 2023 •
edited
Loading

Split out from #30817

Fixes #39641

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels May 17, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2023
@sftim sftim mentioned this pull request May 17, 2023
Closed
@netlify
Copy link

netlify bot commented May 17, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9c26f03
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/646524fabe71190007a22aee
😎 Deploy Preview https://deploy-preview-41195--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Arhell
Arhell reviewed May 18, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a343945e64692c9886e387ad33a50ab75cdb8c08

@Arhell Arhell removed their assignment May 18, 2023
@sftim sftim mentioned this pull request Jun 30, 2023
Closed
@sftim
Copy link
Contributor Author

sftim commented Jun 30, 2023

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jun 30, 2023
@reylejano
Copy link
Member

This PR clarifies requirements for headless svc
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit fd7fa1f into kubernetes:main Jul 1, 2023
@sftim sftim deleted the 20230223_add_detail_headless_service branch July 2, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service concept unclear on port vs targetPort consistency for headless Services
4 participants
@sftim @k8s-ci-robot @reylejano @Arhell