-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace hardcoded GCS URIs with dl.k8s.io #41444
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @kumiDa! |
@kumiDa Thanks for your contribution! It seems that this PR incorporates modifications to files in multiple languages (en, ko). Documentation team follows different procedures for each localization, and we typically don't merge PR that impact multiple languages simultaneously. My suggestion is to divide this into several pull requests, each concentrating on a specific language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 'en' change is duplicated by #41072
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 'en' change is duplicated by #41072
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for pointing the respective PRs that are open which introduce these changes to en version of the docs. |
As per the initiative kubernetes/k8s.io#1571 to move away from the use of GCP project google-containers, this PR fixes kubernetes/k8s.io#2396
The existent references to https://storage.googleapis.com/kubernetes-release in the repo are replaced appropriately with https://dl.k8s.io/