Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide for translating SVG images #41605

Merged

Conversation

mboukhalfa
Copy link
Member

This pull request introduces a new subsection in the localization guide that provides instructions and guidelines for translating SVG images used in the Docs. The guide aims to assist new contributors in understanding the process of translating text within SVG images and outlines the community rules and best practices to follow.

The purpose of this guide is to ensure consistency and accuracy in translated images across different languages, making Kubernetes documentation more accessible to a wider audience.

This PR is associated with the tracking issue: #41603

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim June 12, 2023 15:08
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2023
@mboukhalfa mboukhalfa force-pushed the image-translation-guide/mohammed branch 3 times, most recently from 047aac1 to 6bc1b7c Compare June 12, 2023 15:25
@mboukhalfa
Copy link
Member Author

/assign @stormqueen1990

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

Optional extra feedback if you'd like to make more fixes.

content/en/docs/contribute/localization.md Outdated Show resolved Hide resolved
content/en/docs/contribute/localization.md Show resolved Hide resolved
content/en/docs/contribute/localization.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5a22dbffa3b0af81281f8f555b9b1aa7c6477477

@mboukhalfa mboukhalfa force-pushed the image-translation-guide/mohammed branch from 6bc1b7c to a8546d6 Compare June 12, 2023 19:32
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@netlify
Copy link

netlify bot commented Jun 12, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4737689
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64aed8f46246c50008373c5b
😎 Deploy Preview https://deploy-preview-41605--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mboukhalfa mboukhalfa force-pushed the image-translation-guide/mohammed branch from a8546d6 to b8c8839 Compare June 12, 2023 19:54
@mboukhalfa mboukhalfa force-pushed the image-translation-guide/mohammed branch from b8c8839 to b10ac77 Compare June 13, 2023 15:12
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 94e2c98bd2d7bab5b86f72b89f3b0d6e1f486cb5

@mboukhalfa
Copy link
Member Author

@sftim
Copy link
Contributor

sftim commented Jun 26, 2023

/retitle Add guide for translating SVG images

This avoids an emoji in a commit message. Lots of folks can cope with that, but still I'd like to be conservative.

@k8s-ci-robot k8s-ci-robot changed the title 📖 Adding Guide for Translating SVG Images Add guide for translating SVG images Jun 26, 2023
@mboukhalfa mboukhalfa force-pushed the image-translation-guide/mohammed branch from b10ac77 to 02fc242 Compare June 26, 2023 16:31
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap all the new lines to match the wrapping in the rest of the file. Wrapping the Markdown source helps localization teams work more effectively.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted the auto formatting and pushed the changes again. However, I would like to confirm if this resolves the issue you mentioned regarding wrapping the new lines to match the rest of the file. Please let me know if there's anything else I can do to ensure the formatting meets the localization team's requirements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done please check

@mboukhalfa mboukhalfa force-pushed the image-translation-guide/mohammed branch 2 times, most recently from a425097 to fee1812 Compare June 27, 2023 05:43
@mboukhalfa mboukhalfa requested a review from sftim July 10, 2023 12:33
@mboukhalfa mboukhalfa force-pushed the image-translation-guide/mohammed branch from fee1812 to 4737689 Compare July 12, 2023 16:46
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2023
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa4dd5cc21e2b37b5892c468e06ae255cbc35986

5. **Reviewing and testing**: After making the necessary translations and
converting text to curves, save and review the updated SVG image to ensure
the text is properly displayed and aligned. Check
[Preview your changes locally](https://kubernetes.io/docs/contribute/new-content/open-a-pr/#preview-locally).
Copy link
Member

@reylejano reylejano Jul 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Preview your changes locally](https://kubernetes.io/docs/contribute/new-content/open-a-pr/#preview-locally).
[Preview your changes locally](docs/contribute/new-content/open-a-pr/#preview-locally).

kubernetes.io uses reference paths for links

@reylejano
Copy link
Member

I find the change proposed in this PR to be a valuable addition
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 130e589 into kubernetes:main Jul 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants