-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for translating SVG images #41605
Add guide for translating SVG images #41605
Conversation
047aac1
to
6bc1b7c
Compare
/assign @stormqueen1990 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
Optional extra feedback if you'd like to make more fixes.
LGTM label has been added. Git tree hash: 5a22dbffa3b0af81281f8f555b9b1aa7c6477477
|
6bc1b7c
to
a8546d6
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
a8546d6
to
b8c8839
Compare
b8c8839
to
b10ac77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 94e2c98bd2d7bab5b86f72b89f3b0d6e1f486cb5
|
/retitle Add guide for translating SVG images This avoids an emoji in a commit message. Lots of folks can cope with that, but still I'd like to be conservative. |
b10ac77
to
02fc242
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wrap all the new lines to match the wrapping in the rest of the file. Wrapping the Markdown source helps localization teams work more effectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reverted the auto formatting and pushed the changes again. However, I would like to confirm if this resolves the issue you mentioned regarding wrapping the new lines to match the rest of the file. Please let me know if there's anything else I can do to ensure the formatting meets the localization team's requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try these links:
- https://about.gitlab.com/blog/2016/10/11/wrapping-text/
- https://www.google.com/search?q=how+to+wrap+lines+in+source+code
We (SIG Docs) do prefer wrapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done please check
a425097
to
fee1812
Compare
fee1812
to
4737689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: fa4dd5cc21e2b37b5892c468e06ae255cbc35986
|
5. **Reviewing and testing**: After making the necessary translations and | ||
converting text to curves, save and review the updated SVG image to ensure | ||
the text is properly displayed and aligned. Check | ||
[Preview your changes locally](https://kubernetes.io/docs/contribute/new-content/open-a-pr/#preview-locally). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Preview your changes locally](https://kubernetes.io/docs/contribute/new-content/open-a-pr/#preview-locally). | |
[Preview your changes locally](docs/contribute/new-content/open-a-pr/#preview-locally). |
kubernetes.io uses reference paths for links
I find the change proposed in this PR to be a valuable addition |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request introduces a new subsection in the localization guide that provides instructions and guidelines for translating SVG images used in the Docs. The guide aims to assist new contributors in understanding the process of translating text within SVG images and outlines the community rules and best practices to follow.
The purpose of this guide is to ensure consistency and accuracy in translated images across different languages, making Kubernetes documentation more accessible to a wider audience.
This PR is associated with the tracking issue: #41603