Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: EtcdLearnerMode is beta in v1.29 #42801

Merged
merged 1 commit into from
Nov 3, 2023
Merged

kubeadm: EtcdLearnerMode is beta in v1.29 #42801

merged 1 commit into from
Nov 3, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Aug 31, 2023 •
edited

Since kubernetes/kubernetes#120228 is merged.

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 31, 2023
@netlify
Copy link

netlify bot commented Aug 31, 2023 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 057e4d4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6530cfe1d07713000801039c

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 31, 2023
@sftim
Copy link
Contributor

sftim commented Aug 31, 2023

/retitle [WIP] [placeholder] kubeadm: EtcdLearnerMode is beta in v1.29

You can remove the [WIP] if you hold the PR @pacoxu. We need some way to tell Prow that this isn't ready to merge.

@k8s-ci-robot k8s-ci-robot changed the title [placeholder] kubeadm: EtcdLearnerMode is beta in v1.29 [WIP] [placeholder] kubeadm: EtcdLearnerMode is beta in v1.29 Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Sep 1, 2023

/hold

Thanks for the comments and I will wait to see if there are other FG changes in v1.29 later in this release cycle.
I will update the PR later.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2023
@pacoxu pacoxu changed the title [WIP] [placeholder] kubeadm: EtcdLearnerMode is beta in v1.29 [placeholder] kubeadm: EtcdLearnerMode is beta in v1.29 Sep 1, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2023
@pacoxu pacoxu mentioned this pull request Sep 4, 2023
Open
12 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2023
@pacoxu pacoxu changed the title [placeholder] kubeadm: EtcdLearnerMode is beta in v1.29 kubeadm: EtcdLearnerMode is beta in v1.29 Oct 19, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Oct 19, 2023

/unhold

@sftim do you have time to take a look?

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Nov 3, 2023

/cc @neolit123

neolit123
neolit123 reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0ed559c8ca071877314d17176093ae892957f45

@sftim
Copy link
Contributor

sftim commented Nov 3, 2023

/sig cluster-lifecycle
/approve

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9af50f2 into kubernetes:dev-1.29 Nov 3, 2023
6 checks passed
@pacoxu pacoxu mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@sftim sftim sftim left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacoxu @sftim @k8s-ci-robot @neolit123