-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new blog for etcd learner mode usage in kubeadm join #43095
add a new blog for etcd learner mode usage in kubeadm join #43095
Conversation
59791fd
to
be97e51
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pick some style issues.
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, thanks for the blog!
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
|
||
### Join Nodes to the ETCD Learner Mode Cluster | ||
|
||
Before joining a node to the ETCD learner mode cluster, ensure that the control plane nodes and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before joining a node to the ETCD learner mode cluster, ensure that the control plane nodes and | |
Before joining a worker node to the ETCD learner mode cluster, ensure that the control plane nodes and |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before joining a control-plane node to the etcd learner mode cluster, ensure that the control plane nodes
and all etcd members are healthy.
Before joining a worker node to the etcd learner mode cluster, ensure that the control plane nodes are healthy.
be97e51
to
38f87b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Here's some more feedback. I suggest pushing the publication date back a few days to allow time for reviews etc. Please pick a weekday.
|
||
**Author:** Paco Xu (DaoCloud) | ||
|
||
Kubeadm now supports etcd learner mode, which allows you to enhance the resilience and stability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubeadm now supports etcd learner mode, which allows you to enhance the resilience and stability | |
The [`kubeadm`](/docs/reference/setup-tools/kubeadm/) tool now supports etcd learner mode, which | |
allows you to enhance the resilience and stability |
(main aim here is to use the correct case, “kubeadm” not “Kubeadm”).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the title as well. Is that OK?
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think it'd be useful to show more detail about adding nodes. I would:
- also mention that there should be an odd number of control plane nodes (eventually! - it's OK to briefly have an even number during cluster setup)
- make it clear that the etcd cluster is stacked onto the control plane nodes
- explain what shell command lets you check that etcd is healthy and that a second, third control plane node has joined OK
- explain what shell commend lets you check that the Kubernetes level control-plane aspects are healthy before you add another control plane node
Maybe also:
- mention that adding worker nodes is almost exactly the same as before, and is included for completeness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some etcd cluster check related intro in bf6c784
38f87b0
to
bf6c784
Compare
Thanks for the details comments and more detail suggestions.
I changed it to next Monday. |
content/en/blog/_posts/2023-09-25-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-25-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
6a4b591
to
d5b5b27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tech content LGTM
thanks
content/en/blog/_posts/2023-09-25-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-25-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-25-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-09-25-kubeadm-use-etcd-learner-mode.md
Outdated
Show resolved
Hide resolved
d5b5b27
to
764487f
Compare
Updated. Thanks. |
Thanks /lgtm (side note: this'll go out one day before “Happy 7th Birthday kubeadm”) |
LGTM label has been added. Git tree hash: 45497879d130f7f000dbe166511e8116f03e9d36
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🎉 |
@neolit123 @SataQiu