update hpa with custom metrics #4344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
| @@ -15,7 +15,7 @@ This document describes the current state of Horizontal Pod Autoscaling in Kuber | |||
|
|
|||
| With Horizontal Pod Autoscaling, Kubernetes automatically scales the number of pods | |||
| in a replication controller, deployment or replica set based on observed CPU utilization | |||
| (or, with alpha support, on some other, application-provided metrics). | |||
| (or, with (custom metrics)[https://github.com/kubernetes/community/blob/master/contributors/design-proposals/custom-metrics-api.md] support, on some other, application-provided metrics). | |||
There was a problem hiding this comment.
- Parenthesis are wrong - name should be in [] and link in ()
- why do you remove information about this feature being alpha?
There was a problem hiding this comment.
also can use url: http://git.k8s.io/community/contributors/design-proposals/custom-metrics-api.md
There was a problem hiding this comment.
DirectXMan12
suggested changes
Jul 13, 2017
ahmetb
suggested changes
Jul 18, 2017
| @@ -15,7 +15,7 @@ This document describes the current state of Horizontal Pod Autoscaling in Kuber | |||
|
|
|||
| With Horizontal Pod Autoscaling, Kubernetes automatically scales the number of pods | |||
| in a replication controller, deployment or replica set based on observed CPU utilization | |||
| (or, with alpha support, on some other, application-provided metrics). | |||
| (or, with (custom metrics)[https://github.com/kubernetes/community/blob/master/contributors/design-proposals/custom-metrics-api.md] support, on some other, application-provided metrics). | |||
There was a problem hiding this comment.
also can use url: http://git.k8s.io/community/contributors/design-proposals/custom-metrics-api.md
|
@zouyee Can you address the comments and merge conflict? thx |
tengqm
requested changes
Sep 30, 2017
| @@ -15,7 +15,7 @@ This document describes the current state of Horizontal Pod Autoscaling in Kuber | |||
|
|
|||
| With Horizontal Pod Autoscaling, Kubernetes automatically scales the number of pods | |||
| in a replication controller, deployment or replica set based on observed CPU utilization | |||
| (or, with alpha support, on some other, application-provided metrics). | |||
| (or, with (custom metrics)[https://github.com/kubernetes/community/blob/master/contributors/design-proposals/custom-metrics-api.md] support, on some other, application-provided metrics). | |||
There was a problem hiding this comment.
|
@zouyee could you rebase this PR and fix it? |
|
Ping @zouyee |
|
ping @zouyee |
xiangpengzhao
added
the
size/XS
|
In the interest of moving this small change forward, I'm going to create a duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update hpa with custom metrics which has been updated with v1 version
This change is