Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trouble shooting to include the issue of etcd upgrade #43903

Closed
wants to merge 1 commit into from

Conversation

chendave
Copy link
Member

@chendave chendave commented Nov 13, 2023

For the isse which is reported recently: kubernetes/kubeadm#2957 We'd better to provide some tips to workaround this known issue.

related: kubernetes/kubeadm#2957

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Nov 13, 2023
Copy link

netlify bot commented Nov 13, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 31d5a38
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6552df04200c7900088990c2

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 13, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2023
@chendave
Copy link
Member Author

/cc @neolit123 @SataQiu @pacoxu


## Upgrade failed due to etcd hash is not changed

Only applicable for upgrade from v1.28.0 (v1.28.1, v1.28.2 as well) to v1.28.3 or after.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chendave wants to merge 1 commit into kubernetes:dev-1.29

i don't know if 1.29 is the right branch for this. the bug is in 1.28.1, .2.
let's wait for feedback from k/website maintainers.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@neolit123
Copy link
Member

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Nov 13, 2023
@chendave
Copy link
Member Author

@neolit123 thanks for the detail review and all those comments! all were fixed up!

@neolit123
Copy link
Member

neolit123 commented Nov 13, 2023

/assign @tengqm

PTAL for guidance and approval.

#43903 (comment)

we have a bug in 3 PATCH versions of 1.28 that we want to add a troubleshooting entry for.
later 1.28 versions fix the problem.

should this PR be against dev-1.28, or main?

@chendave note that changing the base branch from the github UI will not work, probably.
you have to store the diff locally somehow, create a new local branch (based on the correct branch - e.g. main) and then you can force push to your chendave:dev-1.29-2.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

For the isse which is reported recently: kubernetes/kubeadm#2957
We'd better to provide some tips to workaround this known issue.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tengqm. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chendave
Copy link
Member Author

@sftim @tengqm pls tell if this is the right branch to base against, it's currently on top of 1.29-dev branch, #43903 (comment).

thanks!

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c2565c35ddf0160a2bcc3555c55f029e41a0e13

@tengqm
Copy link
Contributor

tengqm commented Nov 16, 2023

I'd suggest we put these contents into content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md and retarget the PR to the main branch which is about 1.28.x versions.

@neolit123
Copy link
Member

I'd suggest we put these contents into content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md and retarget the PR to the main branch which is about 1.28.x versions.

SGTM, but we don't want this info to appear in the 1.29 upgrade page.
do we have to clean it after the 1.29 docs are out?

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
PTAL again for approval, @tengqm @sftim
thanks

this is still an open Q, but we can clean it up later
#43903 (comment)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2023
@sftim
Copy link
Contributor

sftim commented Nov 23, 2023

should this PR be against dev-1.28, or main?

We're not using dev-1.28 any more as v1.28 is released. This PR should target main.

@chendave
Copy link
Member Author

@sftim here it is: #44058, pls take a look, thanks!

@neolit123
Copy link
Member

@sftim here it is: #44058, pls take a look, thanks!

why a separate PR?
should we close this one, then?

@neolit123
Copy link
Member

@sftim here it is: #44058, pls take a look, thanks!

why a separate PR? should we close this one, then?

/close
added LGTM to the other one

@k8s-ci-robot
Copy link
Contributor

@neolit123: Closed this PR.

In response to this:

@sftim here it is: #44058, pls take a look, thanks!

why a separate PR? should we close this one, then?

/close
added LGTM to the other one

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants