Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEP-3352] docs for aggregated discovery #45267

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

Jefftree
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2d9b1a4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6602b9f04740f800092d600d

@dipesh-rawat
Copy link
Member

/retitle [WIP] [KEP-3352] docs for aggregated discovery

@k8s-ci-robot k8s-ci-robot changed the title [KEP-3352] docs for aggregated discovery [WIP] [KEP-3352] docs for aggregated discovery Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@fsmunoz
Copy link
Contributor

fsmunoz commented Mar 6, 2024

Hello @Jefftree 👋 !

Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before the deadline Tuesday March 12th 2024 18:00 PST.

Thank you!

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2024
@Jefftree Jefftree changed the title [WIP] [KEP-3352] docs for aggregated discovery [KEP-3352] docs for aggregated discovery Mar 12, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
@katcosgrove
Copy link
Contributor

Hey @Jefftree! Just a reminder that this needs to be reviewed and ready to merge by Docs Freeze on March 26, including a technical review. An exception request will be required if you cannot meet that deadline. Thank you!

cc: @jpbetz @lavalamp @deads2k

@drewhagen
Copy link
Member

@kubernetes/sig-docs-en-owners Can we get an LGTM from docs on this one? The deadline is March 26th 2024 18:00 PT to get this into the release. Thanks!

@drewhagen
Copy link
Member

/milestone 1.30
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Mar 18, 2024
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 18, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Mar 18, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d859a4582b48b27864f159fdde36cd28bb299a5

@Jefftree
Copy link
Member Author

/assign @sftim

@sftim
Copy link
Contributor

sftim commented Mar 21, 2024

Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

I'm short on spare capacity to review at the moment.

/unassign
/assign @divya-mohan0209
(but: it is KubeCon week; reviews in general might not be as prompt as is typical)

@divya-mohan0209 is a very capable reviewer and I am more than happy to allow the auto-assignment of Divya as reviewer to stand. Any other approver is welcome to provide approval, and I'll leave this on my long list of things to check back on.

@drewhagen
Copy link
Member

I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday March 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze.

Thanks!

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Here's some feedback. Now this is graduating to GA, we might need to clarify something around having two headings that have the same text.

content/en/docs/concepts/overview/kubernetes-api.md Outdated Show resolved Hide resolved
content/en/docs/concepts/overview/kubernetes-api.md Outdated Show resolved Hide resolved
content/en/docs/concepts/overview/kubernetes-api.md Outdated Show resolved Hide resolved
content/en/docs/concepts/overview/kubernetes-api.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2024
@fsmunoz
Copy link
Contributor

fsmunoz commented Mar 25, 2024

@Jefftree hello, Release Lead Shadow for 1.30, acting as Docs shadow here; as @drewhagen mentioned above, the Docs Freeze is fast approaching (Tuesday March 26th 18:00 PDT).

From what I've seen, the technical review is still needed (cc @jpbetz @lavalamp @deads2k , could you take a look?)

There are also some pending comments from SIG Docs - could you take a look? I think that with that (technical + Docs) the lgtm and approve process can follow, and hopefully before the freeze deadline. Thanks!

@jpbetz
Copy link
Contributor

jpbetz commented Mar 25, 2024

This one looked good to me last pass.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1025272c99f9d8521e0cbb806995143644c6da3e

@drewhagen
Copy link
Member

Just a heads up that Doc Freeze is approaching fast tomorrow March 26th at 18:00 PDT and starting this cycle, we need to file an Exception after this time.
This one looks pretty close and we'd like to help you get it over the finish line!

@kubernetes/sig-docs-en-owners Does this one look good for an approve from y'all? Thanks!

Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed the one required fix.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fe7cc19f7dcba3f445966f185aa890337bc3b699

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit b28f917 into kubernetes:dev-1.30 Mar 26, 2024
6 checks passed
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants