-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KEP-3352] docs for aggregated discovery #45267
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
/retitle [WIP] [KEP-3352] docs for aggregated discovery |
Hello @Jefftree 👋 ! Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before the deadline Tuesday March 12th 2024 18:00 PST. Thank you! |
37deea2
to
4d80f85
Compare
Hey @Jefftree! Just a reminder that this needs to be reviewed and ready to merge by Docs Freeze on March 26, including a technical review. An exception request will be required if you cannot meet that deadline. Thank you! |
@kubernetes/sig-docs-en-owners Can we get an LGTM from docs on this one? The deadline is March 26th 2024 18:00 PT to get this into the release. Thanks! |
/milestone 1.30 |
/lgtm |
LGTM label has been added. Git tree hash: 1d859a4582b48b27864f159fdde36cd28bb299a5
|
/assign @sftim |
I'm short on spare capacity to review at the moment. /unassign @divya-mohan0209 is a very capable reviewer and I am more than happy to allow the auto-assignment of Divya as reviewer to stand. Any other approver is welcome to provide approval, and I'll leave this on my long list of things to check back on. |
I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday March 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Here's some feedback. Now this is graduating to GA, we might need to clarify something around having two headings that have the same text.
7a302b4
to
294dbbb
Compare
@Jefftree hello, Release Lead Shadow for 1.30, acting as Docs shadow here; as @drewhagen mentioned above, the Docs Freeze is fast approaching (Tuesday March 26th 18:00 PDT). From what I've seen, the technical review is still needed (cc @jpbetz @lavalamp @deads2k , could you take a look?) There are also some pending comments from SIG Docs - could you take a look? I think that with that (technical + Docs) the |
This one looked good to me last pass. /lgtm |
LGTM label has been added. Git tree hash: 1025272c99f9d8521e0cbb806995143644c6da3e
|
Just a heads up that Doc Freeze is approaching fast tomorrow March 26th at 18:00 PDT and starting this cycle, we need to file an Exception after this time. @kubernetes/sig-docs-en-owners Does this one look good for an approve from y'all? Thanks! |
...n/docs/reference/command-line-tools-reference/feature-gates/aggregated-discovery-endpoint.md
Show resolved
Hide resolved
Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I committed the one required fix.
/lgtm
/approve
LGTM label has been added. Git tree hash: fe7cc19f7dcba3f445966f185aa890337bc3b699
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 1.30 |
kubernetes/enhancements#3352