Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [KEP-4346]: feature-gate InformerMetrics to alpha #45273

Closed
wants to merge 1 commit into from
Closed

[WIP] [KEP-4346]: feature-gate InformerMetrics to alpha #45273

wants to merge 1 commit into from

Conversation

chenk008
Copy link
Contributor

@chenk008 chenk008 commented Feb 22, 2024 •
edited

add feature description for InformerMetrics alpha promotion

KEP: kubernetes/enhancements#4346

code PR: kubernetes/kubernetes#123367

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 22, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit bbb21fc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65d6ae571f6b090008bc4226

@chenk008 chenk008 mentioned this pull request Feb 22, 2024
Open
7 tasks
@chenk008 chenk008 changed the title add feature-gate informer metrics Add feature-gate informer metrics Feb 22, 2024
@chenk008 chenk008 marked this pull request as draft February 22, 2024 02:18
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@chenk008 chenk008 changed the title Add feature-gate informer metrics [WIP] [KEP-4346]: feature-gate InformerMetrics to alpha Feb 22, 2024
sftim
sftim reviewed Feb 25, 2024
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates/informer_metrics.md
defaultValue: false
fromVersion: "1.30"
---
Enable support for exposing informer/reflector metrics.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion: add informer and reflector into the Kubernetes glossary, and then refer to those using glossary shortcodes.

Not needed for the alpha

@drewhagen
Copy link
Member

Hello @chenk008 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

@chenk008
Copy link
Contributor Author

chenk008 commented Mar 6, 2024

@drewhagen Sorry, i think the code PR is still under discussion, so it will delay.

@drewhagen
Copy link
Member

drewhagen commented Apr 17, 2024 •
edited

/hold
@chenk008 Kubernetes 1.30 is releasing today.
This PR will need to be targeting the dev-1.31 branch once it is available. Our SIG Release docs team will keep you posted.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@drewhagen
Copy link
Member

You can reopen this in the next release cycle and target dev-1.31. Thanks! :)

@drewhagen drewhagen closed this Apr 17, 2024
@drewhagen
Copy link
Member

Heads up that dev-1.31 branch is created now, if you choose to reopen this for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chenk008 @k8s-ci-robot @drewhagen @sftim