Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Namespace Patching to RBAC good practice #45664

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Add Namespace Patching to RBAC good practice #45664

merged 3 commits into from
Mar 27, 2024

Conversation

smarticu5
Copy link
Contributor

@smarticu5 smarticu5 commented Mar 25, 2024

Updating the RBAC Good Practices guide to include information on Patch operations against Namespaces being a security risk.

Copy link

linux-foundation-easycla bot commented Mar 25, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: smarticu5 / name: Iain Smart (3f990cd, 1ed331c)
  • ✅ login: sftim / name: Tim Bannister (54e1d33)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @smarticu5!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 25, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 25, 2024
Copy link

netlify bot commented Mar 25, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 54e1d33
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66044b03f93cd80008908a28
😎 Deploy Preview https://deploy-preview-45664--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My take. The style nits are important so that people can tell the concept of “services” apart from the Service API.

content/en/docs/concepts/security/rbac-good-practices.md Outdated Show resolved Hide resolved
content/en/docs/concepts/security/rbac-good-practices.md Outdated Show resolved Hide resolved
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@sftim
Copy link
Contributor

sftim commented Mar 26, 2024

/hold

OK to unhold once the reviews I mentioned in #45664 (comment) are done.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c8386ba97cfe7a871077148b265ef7fbb76a0741

@sftim
Copy link
Contributor

sftim commented Mar 27, 2024

/hold cancel
Thanks @IanColdwater

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@sftim
Copy link
Contributor

sftim commented Mar 27, 2024

I'm going to use my maintainer access to fix just the style nits - see https://github.com/kubernetes/website/pull/45664/files#r1539294992

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Drawing on #45664 (comment) (LGTM from review by @IanColdwater)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2e66500573af4e80428a6ad9e6f88b90babb5904

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5e8ee7d into kubernetes:main Mar 27, 2024
6 checks passed
@tabbysable
Copy link
Member

Thanks so much, @smarticu5, for the research here and the followup to call attention to this surprising behavior.

/lgtm

/honk

@k8s-ci-robot
Copy link
Contributor

@tabbysable:
goose image

In response to this:

Thanks so much, @smarticu5, for the research here and the followup to call attention to this surprising behavior.

/lgtm

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smarticu5
Copy link
Contributor Author

Appreciate this is closed now, thanks all. I've added a PoC using a minimal role and rolebinding to my own repo (https://github.com/smarticu5/kubernetes_manifests/tree/main/pocs/namespace-labelling) for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants