-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Namespace Patching to RBAC good practice #45664
Conversation
Welcome @smarticu5! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My take. The style nits are important so that people can tell the concept of “services” apart from the Service API.
Co-authored-by: Tim Bannister <tim@scalefactory.com>
/hold OK to unhold once the reviews I mentioned in #45664 (comment) are done. |
LGTM label has been added. Git tree hash: c8386ba97cfe7a871077148b265ef7fbb76a0741
|
/hold cancel |
I'm going to use my maintainer access to fix just the style nits - see https://github.com/kubernetes/website/pull/45664/files#r1539294992 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Drawing on #45664 (comment) (LGTM from review by @IanColdwater)
LGTM label has been added. Git tree hash: 2e66500573af4e80428a6ad9e6f88b90babb5904
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks so much, @smarticu5, for the research here and the followup to call attention to this surprising behavior. /lgtm /honk |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Appreciate this is closed now, thanks all. I've added a PoC using a minimal role and rolebinding to my own repo (https://github.com/smarticu5/kubernetes_manifests/tree/main/pocs/namespace-labelling) for future reference. |
Updating the RBAC Good Practices guide to include information on Patch operations against Namespaces being a security risk.