-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create super-linter.yml #46037
base: main
Are you sure you want to change the base?
Create super-linter.yml #46037
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN8-GIT-340820 - https://snyk.io/vuln/SNYK-DEBIAN8-GIT-340820 - https://snyk.io/vuln/SNYK-DEBIAN8-LIBGD2-382974 - https://snyk.io/vuln/SNYK-DEBIAN8-POSTGRESQL94-342090 - https://snyk.io/vuln/SNYK-DEBIAN8-POSTGRESQL94-342090
…10c672246c51d [Snyk] Security upgrade node from 6.14.2 to 22.0
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN8-POSTGRESQL94-342090 - https://snyk.io/vuln/SNYK-DEBIAN8-POSTGRESQL94-342090 - https://snyk.io/vuln/SNYK-DEBIAN8-LIBGD2-382974 - https://snyk.io/vuln/SNYK-DEBIAN8-GIT-340820 - https://snyk.io/vuln/SNYK-DEBIAN8-GIT-340820
…89d979b8de796 [Snyk] Security upgrade node from 6.14.2 to 20.13.1
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: <tylerhawthorne@mainh.onmicrosoft.com>
@@ -1,4 +1,4 @@ | |||
FROM node:6.14.2 | |||
FROM node:20.13.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is updating the Dockerfile for each localizations relevant in this case (adding linter)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: #43335 (comment)
Make sure to use Prow for the checks (not GitHub Actions, which as a project we avoid).
I think it would be better to use Prow instead of GHA
Other concerns - Why are you using super-linter instead of linters for each language? I think it is better to properly set up linters for each language. Please note that the super-linter has a large container image and takes time to execute. |
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN12-ZLIB-6008963 - https://snyk.io/vuln/SNYK-DEBIAN12-ZLIB-6008963 - https://snyk.io/vuln/SNYK-DEBIAN12-OPENSSH-7413682 - https://snyk.io/vuln/SNYK-DEBIAN12-GIT-6846203 - https://snyk.io/vuln/SNYK-DEBIAN12-GIT-6846203
…ae073526d67a6 [Snyk] Security upgrade node from 22.0 to 22.4.1
No description provided.