Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create super-linter.yml #46037

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Create super-linter.yml #46037

wants to merge 8 commits into from

Conversation

Hawthorne001
Copy link

No description provided.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 28, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 28, 2024
@Hawthorne001 Hawthorne001 marked this pull request as draft April 28, 2024 06:33
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 28, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a03e002
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6691785ba7f05e00089f971f
😎 Deploy Preview https://deploy-preview-46037--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 28, 2024
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/id Issues or PRs related to Indonesian language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 9, 2024
@k8s-ci-robot k8s-ci-robot added the language/de Issues or PRs related to German language label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign habibrosyad, rlenferink, salaxander for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Hawthorne001
Create go-ossf-slsa3-publish.yml
15b1953 
Signed-off-by: <tylerhawthorne@mainh.onmicrosoft.com>
@Hawthorne001 Hawthorne001 marked this pull request as ready for review June 11, 2024 00:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2024
habibrosyad
habibrosyad reviewed Jun 11, 2024
View reviewed changes
content/de/examples/minikube/Dockerfile
@@ -1,4 +1,4 @@
FROM node:6.14.2
FROM node:20.13.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is updating the Dockerfile for each localizations relevant in this case (adding linter)?

Okabe-Junya
Okabe-Junya requested changes Jun 23, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: #43335 (comment)

Make sure to use Prow for the checks (not GitHub Actions, which as a project we avoid).

I think it would be better to use Prow instead of GHA

@Okabe-Junya
Copy link
Member

Other concerns - Why are you using super-linter instead of linters for each language? I think it is better to properly set up linters for each language.

Please note that the super-linter has a large container image and takes time to execute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcginnis stmcginnis stmcginnis left review comments

@habibrosyad habibrosyad habibrosyad left review comments

@Okabe-Junya Okabe-Junya Okabe-Junya requested changes

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@sftim sftim Awaiting requested review from sftim

@rlenferink rlenferink Awaiting requested review from rlenferink

Assignees
No one assigned
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Hawthorne001 @k8s-ci-robot @Okabe-Junya @stmcginnis @habibrosyad @snyk-bot