-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-24: Graduate Kubernetes' support for AppArmor to GA. #47023
Conversation
/cc @tallclair |
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinayakankugoyal Currently, it appears that this PR is modifying the Chinese localization feature gate file, which is incorrect. This change should be applied to the 'AppArmor ' feature gate description file in English. Please make the necessary correction.
Location for file to be changed: content/en/docs/reference/command-line-tools-reference/feature-gates/apparmor.md
/remove-language zh |
content/en/docs/reference/command-line-tools-reference/feature-gates/apparmor.md
Outdated
Show resolved
Hide resolved
Some early feedback: there are other details we expect to see covered ahead of graduation. Please see:
and check whether https://kubernetes.io/docs/tasks/configure-pod-container/security-context/ needs any update for GA. |
With the new field all annotation based mechanisms are considered deprecated.
That also does not mention other security controls like runAsUser, seccomp but does mention PSS. PSS already has controls for appArmor.
That also does not mention other security controls like runAsUser, seccomp but does mention PSS. PSS already has controls for appArmor.
Good catch! lets fix that in this PR.
AFAIK no clean up steps are required. Good call on updating https://kubernetes.io/docs/tasks/configure-pod-container/security-context/ |
Even so, we expect docs (yes, it should have been done for beta, but the thing still needs documenting). We want this partly for formally telling people that there is a new mechanism, and partly because we "register" annotations by documenting them. |
That annotation is only PSP specific AFAIK. It was a means of specifying what profile should be applied to containers in the event they don't have a profile specified. Support for PSP has long since been deprecated (removed?) and you won't find any reference to that annotation in kubernetes except for PSP docs (which is where it should live?). |
The place to register it is Well-Known Labels, Annotations and Taints, honestly. That's a list of all the registered labels, annotations and taints for the Kubernetes project. |
Hi @vinayakankugoyal since this PR is ready for review, can you remove the draft status? We need to PR in the ready-for-review status before Tuesday, July 16th, 2024 18:00 PST. Thank you! |
content/en/docs/tasks/configure-pod-container/security-context.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/security-context.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not sure why this example is still using annotations:
apparmor.security.beta.kubernetes.io/allowedProfileNames: 'runtime/default' |
Maybe change it to fields.
content/en/docs/tasks/configure-pod-container/security-context.md
Outdated
Show resolved
Hide resolved
PSP has long been deprecated, maybe we should consider removing those docs completely, but we should do so in a separate PR. |
content/en/docs/tasks/configure-pod-container/security-context.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 62d919ce978bdd64d57409cae1e7ed557750dc57
|
Signed-off-by: Vinayak Goyal <vinaygo@google.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SergeyKanzhelev, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: 739a68af5218af3bb531be72b9864f27892e1d90
|
Update the feature gate for AppArmor to Stable stage for 1.31.
With kubernetes/kubernetes#125257 we will be graduating the AppArmor support to GA aka stable. This PR updates the docs to reflect that.
xref kubernetes/enhancements#24