Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature gate for AppArmorFields in v1.30 #47254

Closed
wants to merge 1 commit into from
Closed

Add feature gate for AppArmorFields in v1.30 #47254

wants to merge 1 commit into from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jul 24, 2024

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tengqm. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 24, 2024

✅ Pull request preview available for checking

Name Link
🔨 Latest commit 2406e5c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a0e3d9922f8c0008986132
😎 Deploy Preview https://deploy-preview-47254--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

/sig node security

content/en/docs/reference/command-line-tools-reference/feature-gates/apparmor-fields.md
defaultValue: true
fromVersion: "1.30"
---
Enable AppArmor related security context settings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could make security context a hyperlink or tooltip, but it's better to have something than nothing.

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/security Categorizes an issue or PR as relevant to SIG Security. labels Jul 24, 2024
@drewhagen
Copy link
Member

/sig node

cc: @tallclair @kubernetes/sig-node-leads

Can we please get some help contributing some detail to this feature gate doc? We appreciate it, thanks!

@a-mccarthy a-mccarthy mentioned this pull request Aug 5, 2024
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2024
@tengqm tengqm closed this Nov 12, 2024
@tengqm tengqm deleted the fg-af branch November 12, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@reylejano reylejano Awaiting requested review from reylejano

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/security Categorizes an issue or PR as relevant to SIG Security. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tengqm @k8s-ci-robot @drewhagen @k8s-triage-robot @sftim