kubeadm: add 1.32 documentation #48408

neolit123 · 2024-10-17T16:27:39Z

feature gates:

move PublicKeysECDSA to deprecated (this was done in 1.31)
add NodeLocalCRISocket as alpha for 1.32

update CLI docs

add nodes about new cert features.

revamp implementation details.

netlify · 2024-10-17T16:27:54Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`bbdb8dd`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/674837954860940008a8ed0f

neolit123 · 2024-10-17T16:27:58Z

/sig cluster-lifecycle
/kind feature cleanup

netlify · 2024-10-17T16:37:26Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`bbdb8dd`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6748379587c642000877d025
😎 Deploy Preview	https://deploy-preview-48408--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

content/en/docs/reference/setup-tools/kubeadm/kubeadm-init.md

neolit123 · 2024-11-06T12:49:38Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-upgrade-phase.md

-title: kubeadm upgrade phase
-weight: 90
+title: kubeadm upgrade phases
+weight: 40


making this appear after the kubeadm upgrade page in the list

neolit123 · 2024-11-11T09:05:19Z

/remove-label tide/merge-method-squash

neolit123 · 2024-11-11T09:06:47Z

@neolit123 I noticed that this PR comprises both manually created contents and generated contents. Can/shall we separate them into two PRs?

i split this PR in two commits:

generated ref docs
authored content updates

and removed the squash label.

content/en/docs/reference/setup-tools/kubeadm/implementation-details.md

content/en/docs/reference/setup-tools/kubeadm/kubeadm-init.md

content/en/docs/reference/setup-tools/kubeadm/kubeadm-upgrade-phase.md

tengqm · 2024-11-11T09:34:08Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-upgrade-phase.md

+{{< tabs name="tab-phase" >}}
+{{< tab name="phase" include="generated/kubeadm_upgrade/kubeadm_upgrade_apply_phase.md" />}}
+{{< tab name="preflight" include="generated/kubeadm_upgrade/kubeadm_upgrade_apply_phase_preflight.md" />}}
+{{< tab name="control-plane" include="generated/kubeadm_upgrade/kubeadm_upgrade_apply_phase_control-plane.md" />}}
+{{< tab name="upload-config" include="generated/kubeadm_upgrade/kubeadm_upgrade_apply_phase_upload-config.md" />}}
+{{< tab name="kubelet-config" include="generated/kubeadm_upgrade/kubeadm_upgrade_apply_phase_kubelet-config.md" />}}
+{{< tab name="bootstrap-token" include="generated/kubeadm_upgrade/kubeadm_upgrade_apply_phase_bootstrap-token.md" />}}
+{{< tab name="addon" include="generated/kubeadm_upgrade/kubeadm_upgrade_apply_phase_addon.md" />}}
+{{< tab name="post-upgrade" include="generated/kubeadm_upgrade/kubeadm_upgrade_apply_phase_post-upgrade.md" />}}
+{{< /tabs >}}


I don't think tabs are the best option here.

maybe yes, but the existing approach is to add phases as tabs. changing that seems out of scope for this PR.

we had discussions about these generated kubeadm docs in the past.
ideally the generator should generate hyper links between the various generated pages and create a tree structure.
then these authored pages would not need to import generated pages in tabs and can just link to a top generated page from the tree.

i don't have time to work on something like that, so maybe you or someone else from SIG Docs can submit this as a GSoC or LFX project and a student can pick it up.

tengqm · 2024-11-11T09:34:47Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-upgrade-phase.md


 {{< tabs name="tab-phase" >}}
 {{< tab name="phase" include="generated/kubeadm_upgrade/kubeadm_upgrade_node_phase.md" />}}
 {{< tab name="preflight" include="generated/kubeadm_upgrade/kubeadm_upgrade_node_phase_preflight.md" />}}
 {{< tab name="control-plane" include="generated/kubeadm_upgrade/kubeadm_upgrade_node_phase_control-plane.md" />}}
 {{< tab name="kubelet-config" include="generated/kubeadm_upgrade/kubeadm_upgrade_node_phase_kubelet-config.md" />}}
+{{< tab name="addon" include="generated/kubeadm_upgrade/kubeadm_upgrade_node_phase_addon.md" />}}
+{{< tab name="post-upgrade" include="generated/kubeadm_upgrade/kubeadm_upgrade_node_phase_post-upgrade.md" />}}
 {{< /tabs >}}


Here too.
These phases are not mutual exclusive IIUC.

content/en/docs/reference/setup-tools/kubeadm/implementation-details.md

SataQiu · 2024-11-11T12:43:10Z

/lgtm

k8s-ci-robot · 2024-11-11T12:43:17Z

LGTM label has been added.

Git tree hash: 7a6ec91de9bba7be8e53bd7450044c54b5c7df2a

pacoxu · 2024-11-28T08:10:00Z

content/en/docs/reference/setup-tools/kubeadm/kubeadm-init.md

+`kubeadm.alpha.kubernetes.io/cri-socket` on the Node object. The new file is applied as an instance
+configuration patch, before any other user managed patches are applied when the `--patches` flag
+is used. It contains a single field `containerRuntimeEndpoint` from the
+[KubeletConfiguration file format](/docs/reference/config-api/kubelet-config.v1beta1/).


For upgrade, we will read from kubeadm-flags.env if instance-config.yam does not exist.

Should we mention it?

adding:

If the feature gate is enabled during upgrade, but the file /var/lib/kubelet/instance-config.yaml does not exist yet, kubeadm will attempt to read the CRI socket value from the file /var/lib/kubelet/kubeadm-flags.env.

pacoxu

/lgtm

k8s-ci-robot · 2024-11-28T09:41:52Z

LGTM label has been added.

Git tree hash: 8fc72776cc3e03cdeb22bdc21f09141cb923156f

reylejano · 2024-12-10T17:24:31Z

/approve

k8s-ci-robot · 2024-12-10T17:24:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, reylejano, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/docs/OWNERS~~ [reylejano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added this to the 1.32 milestone Oct 17, 2024

k8s-ci-robot requested a review from dipesh-rawat October 17, 2024 16:27

k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 17, 2024

k8s-ci-robot requested a review from Princesso October 17, 2024 16:27

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2024

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2024

k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 17, 2024

neolit123 mentioned this pull request Nov 4, 2024

[Kubeadm] KEP-4656: Add kubelet instance configuration to configure CRI socket for each node kubernetes/kubernetes#128031

Merged

neolit123 force-pushed the 1.32-kubeadm-docs branch from 9fd532c to 161fa79 Compare November 6, 2024 09:53

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2024

neolit123 force-pushed the 1.32-kubeadm-docs branch from 161fa79 to c7e9a23 Compare November 6, 2024 10:09

tengqm reviewed Nov 6, 2024

View reviewed changes

content/en/docs/reference/setup-tools/kubeadm/kubeadm-init.md Outdated Show resolved Hide resolved

neolit123 changed the title ~~kubeadm: add 1.32 documentation~~ WIP: kubeadm: add 1.32 documentation Nov 6, 2024

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2024

neolit123 force-pushed the 1.32-kubeadm-docs branch 2 times, most recently from 067a100 to 748be86 Compare November 6, 2024 12:48

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2024

neolit123 commented Nov 6, 2024

View reviewed changes

neolit123 mentioned this pull request Nov 6, 2024

Add kubelet instance configuration to configure CRI socket for each node kubernetes/kubeadm#3042

Open

neolit123 force-pushed the 1.32-kubeadm-docs branch 2 times, most recently from 0e04af3 to 6ba0b84 Compare November 6, 2024 13:16

neolit123 changed the title ~~WIP: kubeadm: add 1.32 documentation~~ kubeadm: add 1.32 documentation Nov 6, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2024

kubeadm: update generated reference docs for 1.32

ed06b86

neolit123 force-pushed the 1.32-kubeadm-docs branch from 34f4ffc to 0438334 Compare November 11, 2024 09:04

k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 11, 2024

tengqm reviewed Nov 11, 2024

View reviewed changes

neolit123 force-pushed the 1.32-kubeadm-docs branch from f1a0ce6 to fd03fc9 Compare November 11, 2024 10:34

SataQiu reviewed Nov 11, 2024

View reviewed changes

content/en/docs/reference/setup-tools/kubeadm/implementation-details.md Outdated Show resolved Hide resolved

SataQiu approved these changes Nov 11, 2024

View reviewed changes

neolit123 force-pushed the 1.32-kubeadm-docs branch from 1730ddb to b35c8dd Compare November 11, 2024 12:37

k8s-ci-robot assigned SataQiu Nov 11, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2024

neolit123 mentioned this pull request Nov 27, 2024

1.32: housekeeping tasks kubernetes/kubeadm#3097

Closed

6 tasks

pacoxu reviewed Nov 28, 2024

View reviewed changes

neolit123 force-pushed the 1.32-kubeadm-docs branch from b35c8dd to 39f0209 Compare November 28, 2024 09:18

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2024

k8s-ci-robot requested a review from SataQiu November 28, 2024 09:18

neolit123 requested a review from pacoxu November 28, 2024 09:26

kubeadm: update authored docs for 1.32

bbdb8dd

neolit123 force-pushed the 1.32-kubeadm-docs branch from 39f0209 to bbdb8dd Compare November 28, 2024 09:27

pacoxu approved these changes Nov 28, 2024

View reviewed changes

k8s-ci-robot assigned pacoxu Nov 28, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024

k8s-ci-robot merged commit 426f5e2 into kubernetes:dev-1.32 Dec 10, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubeadm: add 1.32 documentation #48408

kubeadm: add 1.32 documentation #48408

neolit123 commented Oct 17, 2024 •

edited

Loading

netlify bot commented Oct 17, 2024 •

edited

Loading

neolit123 commented Oct 17, 2024

netlify bot commented Oct 17, 2024 •

edited

Loading

neolit123 Nov 6, 2024

neolit123 commented Nov 11, 2024

neolit123 commented Nov 11, 2024

tengqm Nov 11, 2024

neolit123 Nov 11, 2024 •

edited

Loading

tengqm Nov 11, 2024

SataQiu commented Nov 11, 2024

k8s-ci-robot commented Nov 11, 2024

pacoxu Nov 28, 2024

neolit123 Nov 28, 2024 •

edited

Loading

pacoxu left a comment

k8s-ci-robot commented Nov 28, 2024

reylejano commented Dec 10, 2024

k8s-ci-robot commented Dec 10, 2024

kubeadm: add 1.32 documentation #48408

kubeadm: add 1.32 documentation #48408

Conversation

neolit123 commented Oct 17, 2024 • edited Loading

netlify bot commented Oct 17, 2024 • edited Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

neolit123 commented Oct 17, 2024

netlify bot commented Oct 17, 2024 • edited Loading

✅ Pull request preview available for checking

neolit123 Nov 6, 2024

Choose a reason for hiding this comment

neolit123 commented Nov 11, 2024

neolit123 commented Nov 11, 2024

tengqm Nov 11, 2024

Choose a reason for hiding this comment

neolit123 Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

tengqm Nov 11, 2024

Choose a reason for hiding this comment

SataQiu commented Nov 11, 2024

k8s-ci-robot commented Nov 11, 2024

pacoxu Nov 28, 2024

Choose a reason for hiding this comment

neolit123 Nov 28, 2024 • edited Loading

Choose a reason for hiding this comment

pacoxu left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 28, 2024

reylejano commented Dec 10, 2024

k8s-ci-robot commented Dec 10, 2024

neolit123 commented Oct 17, 2024 •

edited

Loading

netlify bot commented Oct 17, 2024 •

edited

Loading

netlify bot commented Oct 17, 2024 •

edited

Loading

neolit123 Nov 11, 2024 •

edited

Loading

neolit123 Nov 28, 2024 •

edited

Loading