Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return css.html partial to the layout #49591

Closed
wants to merge 1 commit into from

Conversation

shurup
Copy link
Member

@shurup shurup commented Jan 29, 2025

Description

Removing the layouts/partials/css.html from the website layout (#48350) led to missing CSS styles for some pages (such as Training and Case Studies). This PR brings this partial back to fix affected CSS styles.

Since @sftim worked with tidying up the <head>, I'm mentioning him to be sure we actually want to have this partial back (perhaps there was some other plan).

Issue

Closes: #49590

Signed-off-by: Dmitry Shurupov <dmitry.shurupov@palark.com>
@shurup shurup added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jan 29, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2025
Copy link

netlify bot commented Jan 29, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5566dae
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6799ed496847dd00080bf9d9
😎 Deploy Preview https://deploy-preview-49591--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -43,6 +43,8 @@
<link rel="stylesheet" href="{{ "css/prism.css" | relURL }}"/>
{{ end -}}

{{ partial "css.html" . -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this inside layouts/partials/hooks/head-end.html

It belongs there (and I missed it in a previous rebase of #48350)

@sftim
Copy link
Contributor

sftim commented Jan 29, 2025

PR #49587 also has this side effect @shurup; we could merge that instead (but the two PRs are likely to conflict, right?)

@shurup
Copy link
Member Author

shurup commented Jan 29, 2025

Wow, I haven't seen your PR! It's definitely a much better improvement. Let's move forward with it.

/close

@k8s-ci-robot
Copy link
Contributor

@shurup: Closed this PR.

In response to this:

Wow, I haven't seen your PR! It's definitely a much better improvement. Let's move forward with it.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Training page rendering is broken
3 participants