Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated docs for k8s components. #6614

Closed

Conversation

steveperry-53
Copy link
Contributor

@steveperry-53 steveperry-53 commented Dec 7, 2017

Update these generated ref docs:

These ref pages are generated by gen_kube_docs.go, which is called by generate-docs.sh.

Note: generate-docs.sh produces other files that I have not included in this PR. For example, generate-docs.sh produces reference docs for kubeadm. I have not included the kubeadm ref docs here, because they are included in #6103. Also, generate-docs.sh produces reference docs for kubectl. I have not included those here, because I will handle them in a separate PR.

This change is Reviewable

@steveperry-53 steveperry-53 added this to the 1.9 milestone Dec 7, 2017
@steveperry-53 steveperry-53 self-assigned this Dec 7, 2017
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Dec 7, 2017

Deploy preview ready!

Built with commit 24bc68b

https://deploy-preview-6614--kubernetes-io-vnext-staging.netlify.com

@steveperry-53 steveperry-53 added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Dec 7, 2017
@dashpole
Copy link
Contributor

dashpole commented Dec 7, 2017

Should this wait until the 1.9 release is cut? I run branchff once a day, which will update these files.

@steveperry-53 steveperry-53 added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Dec 7, 2017
@steveperry-53
Copy link
Contributor Author

@dashpole Yes, I'll update these files at the last minute before the 1.9 release.

@steveperry-53
Copy link
Contributor Author

cc @mengqiy

@steveperry-53
Copy link
Contributor Author

Duplicates #6658. Closing.

@steveperry-53 steveperry-53 deleted the release-1.9 branch December 19, 2017 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants