Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new 1.10 branch with site config #7132

Closed
wants to merge 5 commits into from
Closed

Update new 1.10 branch with site config #7132

wants to merge 5 commits into from

Conversation

Bradamant3
Copy link
Contributor

@Bradamant3 Bradamant3 commented Jan 29, 2018

Some values are temporary (partly to test netlify config); will change at release time.
Apologies for the stray commits -- checked log, not sure what happened, but hope it's a small enough list we can live with it. Thanks!

/assign @zacharysarah


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging ready!

Built with commit 0f6488a

https://deploy-preview-7132--kubernetes-io-vnext-staging.netlify.com

@Bradamant3 Bradamant3 added this to the 1.10 milestone Jan 29, 2018
@zacharysarah
Copy link
Contributor

@Bradamant3 👋 For the stray commits, I'm asking that you please separate them into different PRs. The changes to _config.yml represent a significant change to the repo's release structure. In case we have to revert and/or cherry-pick PRs for the release (it happens), it's better if we can minimize potential conflicts.

I know it's less than ideal from an efficiency standpoint to pick apart two nits. They both look good otherwise. 💛 😅

@Bradamant3 Bradamant3 closed this Jan 30, 2018
@Bradamant3
Copy link
Contributor Author

Closing in favor of a cleaner PR for just the changes to _config.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants