Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HyperVContainer feature gates #7480

Closed
wants to merge 1 commit into from
Closed

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Feb 22, 2018

This PR adds HyperVContainer feature gates to docs.

Refer kubernetes/kubernetes#58751.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Feb 22, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 59386c0

https://deploy-preview-7480--kubernetes-io-master-staging.netlify.com

@xiangpengzhao
Copy link
Contributor

This LGTM. It'd be great if there is a doc to link to, which describes the details of this feature.

@feiskyer
Copy link
Member Author

It'd be great if there is a doc to link to, which describes the details of this feature.

@xiangpengzhao Thanks of reviewing. Links added, PTAL

@tengqm
Copy link
Contributor

tengqm commented Feb 22, 2018

Please use alphabet order in the table and the list.

@xiangpengzhao
Copy link
Contributor

LGTM after addressing @tengqm 's comment :)

@feiskyer
Copy link
Member Author

Sorry, didn't notice there are orders. Fixed.

@xiangpengzhao
Copy link
Contributor

/lgtm
ping @tallclair for another look :)

/assign @chenopis
for approval :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiangpengzhao
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: chenopis

Assign the PR to them by writing /assign @chenopis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@heckj heckj added this to the 1.10 milestone Feb 23, 2018
@heckj
Copy link
Contributor

heckj commented Feb 23, 2018

@feiskyer this is great, but since it’s 1.10 specific it should be targeted to the release-1.10 branch rather than master. Could you please re-target this PR against that branch?

I’ve also applied the 1.10 milestone to this PR to track it against the release.

/assign @chenopis

@feiskyer
Copy link
Member Author

@heckj Thanks. Opened #7502 for 1.10 branch.

@feiskyer feiskyer closed this Feb 24, 2018
@feiskyer feiskyer deleted the hyperv branch February 24, 2018 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants