Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable overriding seLinux type for custom type tags #355

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

slashben
Copy link
Contributor

@slashben slashben commented Dec 18, 2023

Type

enhancement


Description

This PR introduces the ability for users to override the most common SELinux type scp_t with a custom tag that fits their specific environment. This enhancement was prompted by an issue encountered in the Bottlerocket OS environment in AWS.


PR changes walkthrough

Relevant files                                                                                                                                 
Configuration changes
1 files
                                                                                                 


    The changes in this file enable the overriding of the
    SELinux type for custom type tags.

User description

Overview

In different environments, privileged SELinux type tags can differ. In this PR we add capability for the user to override the most common type scp_t with custom tag that fits the give environment.

Additional Information

This issue came around in Bottlerocket OS environment in AWS.

Related issues/PRs:

bottlerocket-os/bottlerocket#3677

Signed-off-by: Ben <ben@armosec.io>
@slashben slashben requested a review from matthyx December 18, 2023 06:02
@codiumai-pr-agent-free codiumai-pr-agent-free bot added the enhancement New feature or request label Dec 18, 2023
Copy link

PR Description updated to latest commit (b3945be)

Copy link

PR Analysis

  • 🎯 Main theme: Enabling the overriding of SELinux type for custom type tags
  • 📝 PR summary: This PR introduces a feature that allows users to override the default SELinux type with a custom tag that fits their specific environment. This enhancement was prompted by an issue encountered in the Bottlerocket OS environment in AWS.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 2, because the PR seems to be straightforward and only involves configuration changes. However, without the actual code diff, it's hard to accurately estimate the effort required.
  • 🔒 Security concerns: No

PR Feedback

  • 💡 General suggestions: It would be beneficial to include some tests that validate the new functionality. Also, providing more context in the PR description about the specific issue encountered in the Bottlerocket OS environment would help reviewers understand the motivation behind this change.

  • 🤖 Code feedback:

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

Co-authored-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
@slashben slashben requested a review from matthyx December 18, 2023 07:15
@slashben slashben merged commit db1db8b into main Dec 18, 2023
5 checks passed
@slashben slashben deleted the feature/control-nodeagent-selinux-type branch December 18, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants