Replace full folder mount to per file mount of extra CA certificates #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben <ben@armosec.io>
matthyx
requested changes
Feb 7, 2025
matthyx
reviewed
Feb 11, 2025
| name: extra-certificates | ||
| namespace: kubescape | ||
| data: | ||
| cert1: Zm9v |
There was a problem hiding this comment.
@slashben it doesn't seem to work...
There was a problem hiding this comment.
See this
it looks like lookup is not easily testable. I don't see a way to mock it, on the other hand I don't know how to accommodate the requirement.
This might not be covered by the unittest, but it works on a real cluster
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
matthyx
force-pushed
the
fix/appending-extra-cas
branch
from
5013f68 to
f00e155
Compare
matthyx
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
kubescape-operatorHelm chart templates to improve the handling of extra CA certificates. The main modification involves iterating over the keys in the specified secret and mounting each key as a separate file instead of overriding the whole directoryChanges to improve handling of extra CA certificates:
charts/kubescape-operator/templates/kubescape/deployment.yaml: Added iteration over secret keys to mount each key as a separate file.charts/kubescape-operator/templates/kubevuln/deployment.yaml: Modified to iterate over secret keys for mounting each key as a separate file.charts/kubescape-operator/templates/node-agent/daemonset.yaml: Updated to iterate over secret keys and mount each key individually.charts/kubescape-operator/templates/operator/deployment.yaml: Changed to iterate over secret keys to mount each key as a separate file.charts/kubescape-operator/templates/synchronizer/deployment.yaml: Revised to iterate over secret keys for mounting each key separately.