Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the detection of public Istio Gateways #645

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

slashben
Copy link
Contributor

This pull request includes significant changes to the rules/exposure-to-internet-via-istio-ingress/raw.rego file, primarily focused on improving the logic for identifying whether a gateway is public and adding debug print statements.

Improvements to gateway exposure logic:

  • Replaced the previous logic for identifying the Istio Ingress Gateway with a new is_gateway_public function that checks if the gateway is exposed via a LoadBalancer service or has a "public" suffix. [1] [2]

Signed-off-by: Ben <ben@armosec.io>
Copy link
Contributor

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@slashben slashben merged commit 28fbe92 into master Dec 10, 2024
25 checks passed
@slashben slashben deleted the fix/detecting-public-istio-gw branch December 10, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants