Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ArgoCD source docs and describe external requests for source plugins #282

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Sep 7, 2023

Description

Changes proposed in this pull request:

  • Introduce ArgoCD source docs
  • Describe external requests for source plugins
  • Update Flux RBAC config to unify with the new approach
  • replace Engine to Agent for name unification

Preview

https://argocd-docs.botkube-docs-dcb.pages.dev/

Related issue(s)

Resolves kubeshop/botkube#1250

@pkosiec pkosiec changed the title Introduce ArgoCD source docs Introduce ArgoCD source docs and describe external requests for source plugins Sep 11, 2023
@pkosiec pkosiec force-pushed the argocd-docs branch 2 times, most recently from 1945114 to 6cc3f82 Compare September 13, 2023 08:11
@pkosiec pkosiec marked this pull request as ready for review September 13, 2023 08:36
@pkosiec pkosiec requested review from PrasadG193 and a team as code owners September 13, 2023 08:36
@pkosiec pkosiec added the enhancement New feature or request label Sep 13, 2023
docs/configuration/source/argocd.md Outdated Show resolved Hide resolved
docs/configuration/source/argocd.md Outdated Show resolved Hide resolved
docs/usage/source/argocd.md Outdated Show resolved Hide resolved
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pkosiec pkosiec merged commit 5b733e1 into kubeshop:main Sep 13, 2023
2 checks passed
@pkosiec pkosiec deleted the argocd-docs branch September 13, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create documentation for ArgoCD plugin
2 participants