Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor notifier to use Bot interface to send events #270

Closed
PrasadG193 opened this issue May 1, 2020 · 3 comments · Fixed by #309 or #662
Closed

[Refactor] Refactor notifier to use Bot interface to send events #270

PrasadG193 opened this issue May 1, 2020 · 3 comments · Fixed by #309 or #662
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@PrasadG193
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

In notifier, we send events by creating new connection to communication medium on every new event. We can reduce number of connections by sending messages via Bot interface.

Describe the solution you'd like

Implement required methods in Bot interface so that it satisfies Notifier interface. Then add Bot object as a notifier in main function

@PrasadG193 PrasadG193 added the enhancement New feature or request label May 1, 2020
@codenio
Copy link
Contributor

codenio commented May 1, 2020

TODO:

@codenio
Copy link
Contributor

codenio commented Jul 1, 2020

In notifier, we send events by creating a new connection to communication medium on every new event.

@PrasadG193 at present, creating a new connection on each event using goroutines, prevents the accumulation of event notifications. I have few thoughts with this

  • would a single connection using the bot interface slow down/choke the event notifications sent to the servers?
  • can we reduce the number of connections by queuing the even notifications and serve them with a fixed number of workers?

@PrasadG193
Copy link
Collaborator Author

I agree. Eventually, we would need to have queuing mechanism. We are also adding audit webhook support, which again increases the number of events BotKube needs to process. We are thinking about refactoring architecture so work on high load.

@mergify mergify bot closed this as completed in #309 Jul 13, 2020
mergify bot pushed a commit that referenced this issue Jul 13, 2020
##### ISSUE TYPE

 - Feature Pull Request

##### SUMMARY

In the notifier, we send events by creating a new connection to the communication medium on every new event. We can reduce the number of connections by sending messages via the Bot interface.

Fixes #270
@PrasadG193 PrasadG193 reopened this Jul 18, 2020
@PrasadG193 PrasadG193 added the good first issue Good for newcomers label Jul 18, 2020
@pkosiec pkosiec removed the good first issue Good for newcomers label Jul 26, 2022
@pkosiec pkosiec self-assigned this Jul 26, 2022
@pkosiec pkosiec added this to the v0.13.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants