-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Refactor notifier to use Bot interface to send events #270
Comments
TODO:
|
@PrasadG193 at present, creating a new connection on each event using goroutines, prevents the accumulation of event notifications. I have few thoughts with this
|
I agree. Eventually, we would need to have queuing mechanism. We are also adding audit webhook support, which again increases the number of events BotKube needs to process. We are thinking about refactoring architecture so work on high load. |
##### ISSUE TYPE - Feature Pull Request ##### SUMMARY In the notifier, we send events by creating a new connection to the communication medium on every new event. We can reduce the number of connections by sending messages via the Bot interface. Fixes #270
Is your feature request related to a problem? Please describe.
In notifier, we send events by creating new connection to communication medium on every new event. We can reduce number of connections by sending messages via Bot interface.
Describe the solution you'd like
Implement required methods in Bot interface so that it satisfies Notifier interface. Then add Bot object as a notifier in main function
The text was updated successfully, but these errors were encountered: