Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement patching remote config #1007

Merged
merged 19 commits into from
Mar 15, 2023
Merged

Implement patching remote config #1007

merged 19 commits into from
Mar 15, 2023

Conversation

josefkarasek
Copy link

@josefkarasek josefkarasek commented Mar 6, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Implement remote config patching suing graphql

Testing

  1. Deploy backend with instructions from cloud PR.

  2. Run botkube go run cmd/botkube/main.go

export CONFIG_PROVIDER_IDENTIFIER="deployment-id..."
export CONFIG_PROVIDER_API_KEY="key:..."
export CONFIG_PROVIDER_ENDPOINT="http://localhost:8080/graphql"
  1. Issue patch requests:
@Botkube enable notifications
@Botkube disable notifications
@Botkube status notifications
@Botkube edit sourcebindings
@Botkube status sourcebindings

Related issue(s)

https://github.com/kubeshop/botkube-cloud/issues/176

@josefkarasek josefkarasek marked this pull request as ready for review March 7, 2023 10:07
@josefkarasek josefkarasek requested a review from a team March 7, 2023 10:07
@josefkarasek josefkarasek requested a review from PrasadG193 as a code owner March 7, 2023 10:07
@josefkarasek josefkarasek requested a review from mszostok March 7, 2023 10:07
@mszostok mszostok self-assigned this Mar 9, 2023
mszostok
mszostok reviewed Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor comments 👍

Disclaimer: I left the gql implementation for other reviewer. I checked only Botkube core source-code.

pkg/config/manager_remote.go Outdated
}

func (m *RemoteConfigPersistenceManager) PersistActionEnabled(ctx context.Context, name string, enabled bool) error {
panic("Implement me")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
panic("Implement me")
return errors.New("PersistActionEnabled is not implemented for GQL manager")

but why it was not covered?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend doesn't support actions yet

https://github.com/kubeshop/botkube-cloud/blob/main/botkube-cloud-backend/internal/domain/deployment/cfg_generator.go#L47

josefkarasek
josefkarasek commented Mar 14, 2023
View reviewed changes
internal/remote/api.go
@@ -0,0 +1,97 @@
package remote
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mszostok any better better place for remote API objects?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For m it's fine 👍

@josefkarasek josefkarasek requested a review from mszostok March 15, 2023 09:24
mszostok
mszostok approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍 Please only fix test issues before merging.

internal/remote/api.go
@@ -0,0 +1,97 @@
package remote
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For m it's fine 👍

Josef Karasek and others added 18 commits March 15, 2023 13:36
@josefkarasek josefkarasek merged commit 1f20a56 into kubeshop:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@mszostok mszostok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josefkarasek @mszostok