Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting real name for Slack interactive events #1039

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Apr 12, 2023

Description

Changes proposed in this pull request:

  • Fix reporting real name for Slack interactive events

The username was empty for audit log events when someone used interactive blocks (e.g. buttons).

@pkosiec pkosiec added the bug Something isn't working label Apr 12, 2023
@pkosiec pkosiec added this to the v1.1.0 milestone Apr 12, 2023
@pkosiec pkosiec requested a review from mszostok April 12, 2023 12:20
@pkosiec pkosiec marked this pull request as ready for review April 12, 2023 12:39
@pkosiec pkosiec requested a review from a team April 12, 2023 12:39
@pkosiec pkosiec requested a review from PrasadG193 as a code owner April 12, 2023 12:39
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkosiec pkosiec merged commit a69f7cf into kubeshop:main Apr 12, 2023
@pkosiec pkosiec deleted the fix-reporting-interactive-msg branch April 12, 2023 13:36
pkosiec added a commit to pkosiec/botkube that referenced this pull request May 11, 2023
pkosiec added a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants