Fix Botkube version constraint during migration

[pkosiec]

Description

Changes proposed in this pull request:

• Fix Botkube version constraint during migration
• Update E2E migration test to cover the case for two executors under executor config group

The actual issue:

   FATA while running application: while merging app configuration: found critical validation errors: 3 errors occurred:
        * Key: 'Config.Actions[show-logs-on-error].Bindings.k8s-default-tools_jJkwz' 'k8s-default-tools_jJkwz' binding not defined in Config.Executors
        * Key: 'Config.Actions[describe-created-resource].Bindings.k8s-default-tools_jJkwz' 'k8s-default-tools_jJkwz' binding not defined in Config.Executors

has been resolved on Cloud side.

Testing

Test this against Botkube Cloud dev setup.

Check out the PR and build the latest CLI:

export IMAGE_TAG=v9.99.9-dev
make release-snapshot-cli
chmod +x ./dist/botkube-cli_darwin_amd64_v1/botkube && cp ./dist/botkube-cli_darwin_amd64_v1/botkube /usr/local/bin/botkube

Then, install Botkube in your k3d cluster

Option 1: Without actions

export ALLOW_KUBECTL=true
export ALLOW_HELM=true
export SLACK_CHANNEL_NAME=botkube-demo \
export SLACK_API_APP_TOKEN=xapp-... \
export SLACK_API_BOT_TOKEN=xoxb-... \
export CLUSTER_NAME=dev
botkube install --version 1.7.0 \
--set communications.default-group.socketSlack.enabled=true \
--set communications.default-group.socketSlack.channels.default.name=${SLACK_CHANNEL_NAME} \
--set communications.default-group.socketSlack.appToken=${SLACK_API_APP_TOKEN} \
--set communications.default-group.socketSlack.botToken=${SLACK_API_BOT_TOKEN} \
--set settings.clusterName=${CLUSTER_NAME} \
--set 'executors.k8s-default-tools.botkube/kubectl.enabled'=${ALLOW_KUBECTL} \
--set 'executors.k8s-default-tools.botkube/helm.enabled'=${ALLOW_HELM}

Option 2: With actions

export ALLOW_KUBECTL=true
export ALLOW_HELM=true
export SLACK_CHANNEL_NAME=botkube-demo \
export SLACK_API_APP_TOKEN=xapp-... \
export SLACK_API_BOT_TOKEN=xoxb-... \
export CLUSTER_NAME=dev
botkube install --version 1.7.0 \
--set communications.default-group.socketSlack.enabled=true \
--set communications.default-group.socketSlack.channels.default.name=${SLACK_CHANNEL_NAME} \
--set communications.default-group.socketSlack.appToken=${SLACK_API_APP_TOKEN} \
--set communications.default-group.socketSlack.botToken=${SLACK_API_BOT_TOKEN} \
--set "communications.default-group.socketSlack.channels.default.bindings.sources={k8s-err-with-logs-events,k8s-create-events}" \
--set settings.clusterName=${CLUSTER_NAME} \
--set 'executors.k8s-default-tools.botkube/kubectl.enabled'=${ALLOW_KUBECTL} \
--set 'executors.k8s-default-tools.botkube/helm.enabled'=${ALLOW_HELM} \
--set 'actions.describe-created-resource.enabled=true' \
--set 'actions.show-logs-on-error.enabled=true'

Migrate it:

botkube login --cloud-dashboard-url http://localhost:3000
botkube migrate --cloud-api-url http://host.k3d.internal:8080/graphql --cloud-dashboard-url http://localhost:3000

After running botkube, run:

@Botkube list executors

and see two executors there instead of one (that was a bug).

Related issue(s)

Resolves #1321

[madebyrogal]

Works perfect!

No issue with executors list

Tested both options with and without actions