-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled Plugins Report #1374
Enabled Plugins Report #1374
Conversation
3359bf8
to
1501e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments after code review 🙂 Didn't test it yet.
3423c99
to
dbc47b5
Compare
dbc47b5
to
f92c7a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, I'm about to test the changes in next few minutes and approve it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Good job!
Description
Changes proposed in this pull request:
Testing
internal/analytics/segment_reporter.go:36
set APIKey (you can find it here: https://app.segment.com/kubeshop-dev-botkube/sources/botkube_agent/settings/keys)PluginConfig
Related issue(s)