Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resilience of E2E and integration tests #1406

Merged
merged 8 commits into from
Mar 11, 2024
Merged

Improve resilience of E2E and integration tests #1406

merged 8 commits into from
Mar 11, 2024

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Mar 6, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Force remove Cloud resources when Botkube uninstall timeouts
  • Do not uninstall Botkube on failure, always dump logs
  • Fix waiting on bot after restart
  • Fix overwriting artifacts from multiple jobs
  • Fix waiting for Botkube Helm chart uninstall

Testing

No need to do it, CI tests it.

@pkosiec pkosiec added ci Related to CI pipelines other Internal, no user-facing changes. labels Mar 6, 2024
@pkosiec pkosiec added this to the v1.10.0 milestone Mar 6, 2024
@pkosiec pkosiec changed the title Improve resilience of E2E tests Improve resilience of E2E and integration tests Mar 7, 2024
@pkosiec pkosiec marked this pull request as ready for review March 8, 2024 22:23
@pkosiec pkosiec requested a review from PrasadG193 as a code owner March 8, 2024 22:23
@pkosiec pkosiec requested review from a team and madebyrogal March 8, 2024 22:23
madebyrogal
madebyrogal approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@madebyrogal madebyrogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job
Just small typos

.github/actions/cloud-slack-e2e/action.yaml Outdated Show resolved Hide resolved
.github/workflows/branch-build.yml Outdated Show resolved Hide resolved
test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go Outdated Show resolved Hide resolved
test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go Show resolved Hide resolved
@pkosiec pkosiec merged commit 3f92298 into main Mar 11, 2024
22 checks passed
@pkosiec pkosiec deleted the fix-e2e-tests branch March 11, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebyrogal madebyrogal madebyrogal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
ci Related to CI pipelines other Internal, no user-facing changes.
Projects
Botkube
Status: Done
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @madebyrogal