Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cloud commands, make sure segment doesn't spam logs with errors #1477

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Remove cloud commands, make sure segment doesn't spam logs with errors #1477

merged 2 commits into from
Nov 7, 2024

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Nov 7, 2024

Description

Changes proposed in this pull request:

  • Remove cloud commands, make sure segment doesn't spam logs with errors

@mszostok mszostok requested a review from PrasadG193 as a code owner November 7, 2024 12:03
@mszostok mszostok requested review from a team and pkosiec November 7, 2024 12:03
pkosiec
pkosiec approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mszostok mszostok added the other Internal, no user-facing changes. label Nov 7, 2024
@mszostok mszostok enabled auto-merge (squash) November 7, 2024 12:06
@mszostok mszostok added the ci Related to CI pipelines label Nov 7, 2024
@mszostok mszostok merged commit 4aedcba into kubeshop:main Nov 7, 2024
15 of 17 checks passed
@mszostok mszostok deleted the clear-cli branch November 7, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
ci Related to CI pipelines other Internal, no user-facing changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec