Add e2e test for executing kubectl command on forbidden verbs and resources #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Oct 1, 2020
Comment on lines
+86
to
+89
| "BotKube notifier showconfig": { | ||
| command: "notifier showconfig", | ||
| expected: "<@U023BECGF> notifier showconfig", | ||
| }, |
There was a problem hiding this comment.
@anoopmsivadas Can you please remove this part. This is already being addressed in the separate PR.
The rest looks good to me
There was a problem hiding this comment.
@PrasadG193 so I have to remove this part and create a new pull request, right?
|
I'm closing this PR. will try not to make same mistakes with git |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
Added a e2e test kubectl command with forbidden verb and forbidden resource. Another one for kubctl command with allowed verb and forbidden resource
Fixes #350