-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONTRIBUTING.md #79
Conversation
9b85660
to
31117a3
Compare
Add section to run BotKube outside cluster
|
@PrasadG193 Thanks, will consider adding that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
To avoid build failures in travis CI, run
./hack/verify-*.sh
to check if the code is properly formatted, linted & vendor directory is present. -
And also mention -
if the PR is approved, please squash all the commits and rebase with develop for your PR to be merged
Yes, we should add that, thanks.
Personally I don't think squashing all the commits every time is a good idea, if you take a look at this PR transtats/transtats#160. It would have been hard to find out which change is done for what reason if we squash all the commits. I like to leave it to the contributor to decide which commits go to the devel branch. If there are small fixing commits we can always ask them to squash those commits into proper commits. Doing this also helps one to find out reason for a change by running |
Yes, rather than asking to squash all commits, we can request to squash the unimportant commits. |
Yes, that makes more sense. We can say something similar |
a208776
to
606956d
Compare
@PrasadG193 can you please check the instructions of 'Build and run BotKube locally' once, as I don't have Mattermost/Slack workspace configured with BotKube to test that. |
606956d
to
97be91a
Compare
This PR depends on #89 |
97be91a
to
40863bb
Compare
@bhavin192 Can you please rebase your branch with develop? |
40863bb
to
5be99a5
Compare
@ssudake21 done |
5be99a5
to
48841a5
Compare
Thanks. LGTM |
@bhavin192 can you please rebase with develop? |
- This makes it easy for someone new to start working on BotKube - Adds instructions to build BotKube from source code - Based on https://github.com/jaegertracing/jaeger-client-python/blob/master/CONTRIBUTING.md which is Apache 2.0 licensed Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
48841a5
to
4c98a39
Compare
@PrasadG193 yes, done :) |
https://github.com/jaegertracing/jaeger-client-python/blob/master/CONTRIBUTING.md
which is Apache 2.0 licensed