[Travis CI] don't push container image for PR builds #94

bhavin192 · 2019-05-17T17:16:20Z

Makes sure that image on Docker hub is updated only for commits to
develop branch and not for PRs
ref:
https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
As PRs from contributors don't have access to secrets, builds are failing with error like this one, https://travis-ci.org/infracloudio/botkube/builds/533893897#L580

- Makes sure that image on Docker hub is updated only for commits to develop branch and not for PRs - ref: https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>

sanketsudake · 2019-05-17T17:57:18Z

LGTM.Please go ahead and merge. Thanks for quick fix.

PrasadG193 · 2019-05-17T18:08:24Z

Thanks @bhavin192 for catching and fixing this

bhavin192 requested review from sanketsudake and PrasadG193 May 17, 2019 17:16

PrasadG193 approved these changes May 17, 2019

View reviewed changes

PrasadG193 merged commit 8017492 into kubeshop:develop May 17, 2019

bhavin192 mentioned this pull request May 31, 2019

Make develop as a default branch #91

Closed

Provide feedback