Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Splash screen backgorund && check window.isDestroyed #491

Merged
merged 1 commit into from
Oct 7, 2021
Merged

fix: Splash screen backgorund && check window.isDestroyed #491

merged 1 commit into from
Oct 7, 2021

Conversation

erdkse
Copy link
Contributor

@erdkse erdkse commented Oct 7, 2021

This PR...

Changes

  • Set background colour black to SplashScreen body
  • Check if the window is destroyed

Fixes

How to test it

Screenshots

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@erdkse erdkse merged commit af695fd into main Oct 7, 2021
@erdkse erdkse deleted the erdikose/fix/splash-screen-destroyed-window branch October 7, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devcatalin devcatalin devcatalin approved these changes

@olensmar olensmar Awaiting requested review from olensmar olensmar is a code owner

@kambydyne kambydyne Awaiting requested review from kambydyne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erdkse @devcatalin