Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove NGINX security headers from UI #200

Merged
merged 1 commit into from
Aug 1, 2024
Merged

feat: remove NGINX security headers from UI #200

merged 1 commit into from
Aug 1, 2024

Conversation

dejanzele
Copy link
Collaborator

Remove hardcoded NGINX security headers as that should be configured by customers based on their security preferences.

Also, the configuration-snippet annotation needs to be explicitly enabled in NGINX which causes more friction to customers.

Checklist:

  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My CI is green.

@dejanzele dejanzele requested a review from a team as a code owner August 1, 2024 09:43
@dejanzele dejanzele merged commit 1d370d4 into main Aug 1, 2024
3 checks passed
@dejanzele dejanzele deleted the feat/remove-security-headers branch August 1, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypoplavs ypoplavs ypoplavs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dejanzele @ypoplavs