Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

fix: scrape junit report #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: scrape junit report #54

wants to merge 1 commit into from

Conversation

the-fine
Copy link

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@nicufk nicufk changed the title scrape junit report fix: scrape junit report Aug 26, 2022
nicufk
nicufk approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@nicufk nicufk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vsukhin
vsukhin approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@vsukhin vsukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit to me. have you tested it out?

exu
exu reviewed Aug 29, 2022
View reviewed changes
pkg/runner/cypress.go

junitReportPath := filepath.Join(path, "results/junit.xml")
junitReportPath := filepath.Join(path, "reports/report.xml")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why file name changed ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@exu exu exu left review comments

@nicufk nicufk nicufk approved these changes

@vsukhin vsukhin vsukhin approved these changes

@vLia vLia Awaiting requested review from vLia

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the-fine @exu @vsukhin @nicufk