Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: executor api #447

Merged
merged 15 commits into from
Oct 27, 2021
Merged

feat: executor api #447

merged 15 commits into from
Oct 27, 2021

Conversation

exu
Copy link
Member

@exu exu commented Oct 26, 2021 •
edited
Loading

Pull request description

Executor API for getting listing and deleting executor resources with API use
closes #364

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@exu exu requested review from olensmar and hamzahsn October 26, 2021 11:29
@exu exu changed the title feat: executor api [WIP] feat: executor api Oct 26, 2021
jasmingacic
jasmingacic approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@jasmingacic jasmingacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like work in progress but i will approve it regardless

@exu exu changed the title [WIP] feat: executor api feat: executor api Oct 27, 2021
jasmingacic
jasmingacic suggested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@jasmingacic jasmingacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two remarks regarding deletion.
We should allow users to remove all executors in a namespace.

cmd/kubectl-testkube/commands/executors/delete_executor.go Show resolved Hide resolved
internal/app/api/v1/executor.go Show resolved Hide resolved
olensmar
olensmar reviewed Oct 27, 2021
View reviewed changes
api/v1/testkube.yaml Outdated Show resolved Hide resolved
olensmar
olensmar reviewed Oct 27, 2021
View reviewed changes
api/v1/testkube.yaml
content:
application/json:
schema:
$ref: '#/components/schemas/ExecutorCreateRequest'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CreateExecutorRequest?

olensmar
olensmar reviewed Oct 27, 2021
View reviewed changes
api/v1/testkube.yaml Outdated Show resolved Hide resolved
olensmar
olensmar reviewed Oct 27, 2021
View reviewed changes
api/v1/testkube.yaml Outdated
type: string
type: array
uri:
description: URI for rest based executors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be a service-name instead!?

olensmar
olensmar reviewed Oct 27, 2021
View reviewed changes
api/v1/testkube.yaml Outdated Show resolved Hide resolved
olensmar
olensmar reviewed Oct 27, 2021
View reviewed changes
api/v1/testkube.yaml Outdated Show resolved Hide resolved
olensmar
olensmar approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@olensmar olensmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec lgtm!

@exu exu merged commit 8238d23 into main Oct 27, 2021
@exu exu deleted the jace/feature/executors-api branch October 27, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olensmar olensmar olensmar approved these changes

@jasmingacic jasmingacic jasmingacic approved these changes

@fog1985 fog1985 Awaiting requested review from fog1985

@nicufk nicufk Awaiting requested review from nicufk

@hamzahsn hamzahsn Awaiting requested review from hamzahsn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executors CLI command
3 participants
@exu @olensmar @jasmingacic