Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry-pick: avoid COLLSCAN in favor of PROJECTION_COVERED while counting execution totals #4864

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Jan 8, 2024

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for testkube-docs-preview canceled.

Name Link
🔨 Latest commit 201ddb3
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/659ba9f500404d0008fbb5c0

@rangoo94 rangoo94 changed the title fix: cherry-pick avoid COLLSCAN in favor of PROJECTION_COVERED while counting execution totals fix: cherry-pick: avoid COLLSCAN in favor of PROJECTION_COVERED while counting execution totals Jan 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f5bf835) 26.14% compared to head (201ddb3) 26.14%.

Files Patch % Lines
pkg/repository/result/mongo.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4864      +/-   ##
==========================================
- Coverage   26.14%   26.14%   -0.01%     
==========================================
  Files         257      257              
  Lines       23428    23431       +3     
==========================================
  Hits         6125     6125              
- Misses      16670    16673       +3     
  Partials      633      633              
Flag Coverage Δ
integrationtests 6.98% <0.00%> (-0.01%) ⬇️
unittests 21.17% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rangoo94 rangoo94 merged commit b177997 into main Jan 8, 2024
14 checks passed
@rangoo94 rangoo94 deleted the hotfix/performant-execution-totals branch January 8, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants