Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [TKC-2208] refactor webhook disabling #5658

Merged
merged 18 commits into from
Jul 16, 2024

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Jul 11, 2024

Pull request description

  • deprecate webhook disabling in test, suites, workflows
  • show disable webhook flag in executions
  • remove double disable/enable flags

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for testkube-docs-preview canceled.

Name Link
🔨 Latest commit fe5b7d6
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/66964e9e87c2ae0007429e39

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin changed the title feat: refactor webhook disabling feat: [TKC-2208] refactor webhook disabling Jul 12, 2024
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin marked this pull request as ready for review July 15, 2024 13:07
@vsukhin vsukhin requested review from a team as code owners July 15, 2024 13:07
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin merged commit bb5f7bd into develop Jul 16, 2024
11 checks passed
@vsukhin vsukhin deleted the vsukhin/feature/refactor-webhook-disabling branch July 16, 2024 10:50
vsukhin added a commit that referenced this pull request Jul 23, 2024
* fix(testworkflows): displaying events (#5652)

* feat: remove test workflow notifications

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: remove duplicated param

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* featL refactor disable webhooks

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: dep update

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: add deprecated cli param

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: update docs

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: remove enable flag

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: update webhooks docs

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: add disable webhooks to execution

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: show more fields in twe

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: pass disable webhooks for test suites

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fixL format execution output

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: pass disable webhooks flag to execute operation

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: rename var

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

* fix: dep update

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>

---------

Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Co-authored-by: Dawid Rusnak <dawid@drcode.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants