Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: TKC:2213: add support for defining image credentials cache TTL #5660

Merged
merged 1 commit into from
Jul 17, 2024
Merged

feat: TKC:2213: add support for defining image credentials cache TTL #5660

merged 1 commit into from
Jul 17, 2024

Conversation

dejanzele
Copy link
Contributor

@dejanzele dejanzele commented Jul 12, 2024 •
edited

Pull request description

Testkube caches the image pull secrets indefinitely and this can cause issues if the image registry auth gets rotated.
This PR adds support for defining a TTL for the image pull secrets.

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

  • Issue where customers reported stale image pull credentials being used in Testkube while inspecting image via Skopeo

@dejanzele dejanzele requested a review from a team as a code owner July 12, 2024 03:09
@netlify Netlify
Copy link

netlify bot commented Jul 12, 2024 •
edited

✅ Deploy Preview for testkube-docs-preview canceled.

Name Link
🔨 Latest commit f6610bf
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/6697cd8ca408ef00081d8d3e

@dejanzele dejanzele changed the title feat: add support for defining image credentials cache TTL feat: TKC:2213: add support for defining image credentials cache TTL Jul 12, 2024
@dejanzele dejanzele mentioned this pull request Jul 12, 2024
Merged
6 tasks
rangoo94
rangoo94 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@rangoo94 rangoo94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, possible minor improvements for the interface

pkg/cache/cache.go Outdated Show resolved Hide resolved
pkg/cache/inmem.go Outdated Show resolved Hide resolved
@dejanzele dejanzele force-pushed the feat/image-secrets-cache branch 3 times, most recently from c7e24fb to e344237 Compare July 16, 2024 07:11
rangoo94
rangoo94 approved these changes Jul 16, 2024
View reviewed changes
pkg/cache/inmem.go Show resolved Hide resolved
pkg/imageinspector/secretfetcher.go Show resolved Hide resolved
@dejanzele dejanzele force-pushed the feat/image-secrets-cache branch 3 times, most recently from 73ad356 to 921b61e Compare July 17, 2024 13:16
@dejanzele dejanzele merged commit 4e3477f into develop Jul 17, 2024
11 checks passed
@dejanzele dejanzele deleted the feat/image-secrets-cache branch July 17, 2024 14:53
dejanzele added a commit that referenced this pull request Jul 19, 2024
@dejanzele
add support for defining TTL for image credentials cache (#5660)
21e5ed1
vsukhin pushed a commit that referenced this pull request Jul 23, 2024
@dejanzele @vsukhin
add support for defining TTL for image credentials cache (#5660)
b033314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rangoo94 rangoo94 rangoo94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dejanzele @rangoo94